Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add nested layers live demo to cascade layers page #33998

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: add nested layers live demo to cascade layers page #33998

merged 2 commits into from
Jun 10, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner June 7, 2024 11:06
@OnkarRuikar OnkarRuikar requested review from bsmth and removed request for a team June 7, 2024 11:06
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed labels Jun 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-06-07 13:45:30)

bsmth
bsmth approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Onkar. This section takes a bit of re-reading, but I think the improvements are good. One comment for you to have a look at, but I would leave a +1 on it 👍🏻

@bsmth bsmth merged commit 4a7f7ed into mdn:main Jun 10, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the learn_cascade_layers branch June 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No example for nested cascade layers
2 participants
@OnkarRuikar @bsmth