Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileReader.readyState: combine value table and list #33569

Merged
merged 6 commits into from
May 13, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

for FileReader.readyState, combine the value table and the value list which both intended to provide information about the value of the property

also a tiny fix according to the template - move Value section before the Examples section

Motivation

Additional details

Related issues and pull requests

relates to mdn/translated-content#20165

@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels May 12, 2024
Copy link
Contributor

github-actions bot commented May 12, 2024

Preview URLs

(comment last updated: 2024-05-13 07:11:46)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review May 12, 2024 20:07
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner May 12, 2024 20:07
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team May 12, 2024 20:07
Co-authored-by: Hamish Willee <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skyclouds2001 - LGTM

@hamishwillee hamishwillee merged commit 541c4d1 into mdn:main May 13, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the FileReader.readyState branch May 14, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants