Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Increase PR size labels from S to XL #31986

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 29, 2024

Description

Based on some data from 2023, my rough estimate from 6000 content PRs from 2023 was:

  • 2000 PRs have less than 3LoC
  • 730 PRs in the 3-5LoC (inclusive) range
  • 1700 PRs in the 6-50LoC (inclusive) range
  • 1000 PRs less than 500LoC (50 - 500)
  • ~600 PRs more than 500LoC

Decided to combine the 0-2 & 3-5 segment with XS so we have the following labels:

Size LoC
XS 0-5
S 6-50
M 51-500
L 501-1000
XL 1001+

Motivation

Make the labels a little more accurate, and a little more evenly distributed relative to typical Content PRs.

Additional details

@bsmth bsmth requested a review from a team as a code owner January 29, 2024 16:04
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Jan 29, 2024
@bsmth
Copy link
Member Author

bsmth commented Jan 30, 2024

Thank you @caugner 🙏🏻

@bsmth bsmth merged commit bf3ec9e into mdn:main Jan 30, 2024
7 of 8 checks passed
@bsmth bsmth deleted the pr_size_labels branch January 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants