Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Add perms for PR labeler #31738

Merged
merged 4 commits into from
Jan 16, 2024
Merged

chore(ci): Add perms for PR labeler #31738

merged 4 commits into from
Jan 16, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 16, 2024

@bsmth bsmth requested a review from a team as a code owner January 16, 2024 13:12
@OnkarRuikar
Copy link
Contributor

The trigger was pull_request_target before. In case of pull_request the GITHUB_TOKEN doesn't get write perms. You need to either change the trigger or provide token with elevated permissions.

@bsmth
Copy link
Member Author

bsmth commented Jan 16, 2024

Thanks @OnkarRuikar

The trigger was pull_request_target before.

That's right, I was hoping to get rid of this.

provide token with elevated permissions

I'm assuming the changes in this PR cover that, right?

@bsmth
Copy link
Member Author

bsmth commented Jan 16, 2024

I guess I have to revert to pull_request_target: https://github.com/actions/labeler#permissions

@OnkarRuikar
Copy link
Contributor

OnkarRuikar commented Jan 16, 2024 •
edited
Loading

I'm assuming the changes in this PR cover that, right?

Nope, permissions: key is further tightening on already available permissions to the GITHUB_TOKEN.

@bsmth bsmth requested a review from LeoMcA January 16, 2024 14:19
@bsmth
Copy link
Member Author

bsmth commented Jan 16, 2024

Going to merge to get CI green as some other PRs are blocked by this now. Thank you, both!

@bsmth bsmth merged commit a457cfe into mdn:main Jan 16, 2024
6 of 7 checks passed
@bsmth bsmth deleted the size-labeler-perms branch January 16, 2024 14:38
This was referenced Jan 17, 2024
Merged
Merged
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@bsmth @dipikabh
chore(ci): Add perms for PR labeler (mdn#31738)
0c9dfd2 
* chore(ci): Add perms for PR labeler

* chore(ci): Add perms for PR labeler

* chore(ci): Revert to pull_request_target for PR labeler

* chore(ci): Restrict perms in pr labeler, 'persist-credentials: false' in checkout step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoMcA LeoMcA Awaiting requested review from LeoMcA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsmth @OnkarRuikar @LeoMcA