Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svg): Add usage note on deprecation of data URIs in use href attr #31684

Merged
merged 7 commits into from
Jan 17, 2024
Merged

feat(svg): Add usage note on deprecation of data URIs in use href attr #31684

merged 7 commits into from
Jan 17, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 12, 2024 •
edited
Loading

For good measure, adding a warning box to <use> about these cases:

<svg>
  <use href="data:image/svg+xml;base64,PHN2ZyB4bWxucz0i...#x" />
</svg>
<use>
  <set attributeName="href" to="data:image/svg+xml;base64,PHN2ZyB4bWxuc..."/>
</use>
use.setAttribute("href", "data:image/svg+xml;base64,PHN2ZyB4...

Related issues and pull requests:

@bsmth bsmth added this to the FF122: Jan 23rd milestone Jan 12, 2024
@bsmth bsmth requested review from a team and Ryuno-Ki and removed request for a team January 12, 2024 16:37
@github-actions github-actions bot added the Content:SVG SVG docs label Jan 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-01-17 18:15:20)

@bsmth bsmth mentioned this pull request Jan 15, 2024
Closed
13 tasks
dipikabh
dipikabh requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bsmth. I've added a few suggestions.

files/en-us/web/svg/element/use/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Jan 17, 2024
@bsmth bsmth requested a review from dipikabh January 17, 2024 16:43
dipikabh
dipikabh approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit with the angle brackets around set, but leaving my +1.
Thank you for the updates!

files/en-us/web/svg/element/use/index.md Outdated Show resolved Hide resolved
@bsmth
Copy link
Member Author

bsmth commented Jan 17, 2024

Super, thank you!

@bsmth bsmth merged commit 5bc94b3 into mdn:main Jan 17, 2024
8 checks passed
@bsmth bsmth deleted the 31111-svg-use-usage-note branch January 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@Ryuno-Ki Ryuno-Ki Awaiting requested review from Ryuno-Ki

@pepelsbey pepelsbey Awaiting requested review from pepelsbey

Assignees
No one assigned
Labels
Content:SVG SVG docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
Firefox 122: Jan 23rd
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmth @dipikabh