Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move audio and video guides under Web/Media #30766

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Dec 4, 2023

Part of openwebdocs/project#185

The audio and video guides under Web/Guide are better than the others under Web/Media; that way:

  • they are together with all the similar guides
  • they don't clutter Web/Guide

In the future, we may want to assess and rewrite all that is below Web/Media, but having these articles all together is helpful for the web developers as they'll have a complete sidebar to navigate from one to the others.

@teoli2003 teoli2003 requested a review from a team as a code owner December 4, 2023 08:00
@teoli2003 teoli2003 requested review from zfox23 and removed request for a team December 4, 2023 08:00
@github-actions github-actions bot added the Content:Media Media docs label Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@zfox23
Copy link
Contributor

zfox23 commented Dec 4, 2023

Thanks for your contribution, @teoli2003. Can you please help me understand this language here?

The audio and video guides under Web/Guide are better than the others under Web/Media; that way:

I'm struggling to understand "...are better than the others under... -> that way".

Can you please rephrase?

@teoli2003
Copy link
Contributor Author

teoli2003 commented Dec 4, 2023

The audio and video guides under Web/Guide are better located under Web/Media. (As all other media-related guides are there, and there is an automatic sidebar for all of them)

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Dec 4, 2023
Copy link
Contributor

@zfox23 zfox23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the links referenced by our bot in this comment?

@teoli2003
Copy link
Contributor Author

Yep, we always forgot them; a yari PR is waiting to be reviewed for months to fix internal links when we move pages...

We would have detected them using the flaw dashboard, but it is always better to fix them directly.

I also noticed that the sidebars were not all compatible, so I fixed these, too (this sidebar macro is far from perfect, but it is outside the scope of this PR to improve it, as it is used elsewhere).

@teoli2003 teoli2003 requested a review from zfox23 December 4, 2023 18:15
@zfox23 zfox23 merged commit cfe622c into mdn:main Dec 4, 2023
8 checks passed
yin1999 added a commit to mdn/translated-content that referenced this pull request Dec 5, 2023
yin1999 added a commit to mdn/translated-content that referenced this pull request Dec 5, 2023
* zh-cn: sync translated content

* Redirect Web/Guide/Performance to Web/Performance

ref: mdn/content#30767

* Move audio and video guides under Web/Media

ref: mdn/content#30766

---------

Co-authored-by: allo <[email protected]>
estelle pushed a commit to estelle/content that referenced this pull request Dec 5, 2023
* Move audio and video guides under Web/Media

* Fix redirects + sidebars

* Fix last flaw

* Fix last sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Media Media docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants