-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editorial review — Related website sets docs #30654
Conversation
…tent into related-website-sets
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Chris Fredrickson <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
@teoli2003 thanks for the fabulous review! I have responded to all your comments, so the bulk of the content is now ready for another run through. I've also added some new information about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Related website sets docs * Rest of required content * Fix broken link * Updated status for RWS * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/privacy/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix description list linter mess * Fixes for cfredric tech review comments * address cfredric and tunetheweb feedback * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * More tinkering with descriptions * more small tweaks, link fix * Fix quote style - single to double * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/http/cookies/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/hasstorageaccess/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccess/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccess/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * responding to the rest of teoli2003s comments * Add RWS well-known file and security information --------- Co-authored-by: Chris Fredrickson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Perrier <[email protected]>
* Related website sets docs * Rest of required content * Fix broken link * Updated status for RWS * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/privacy/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix description list linter mess * Fixes for cfredric tech review comments * address cfredric and tunetheweb feedback * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Chris Fredrickson <[email protected]> * More tinkering with descriptions * more small tweaks, link fix * Fix quote style - single to double * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/related_website_sets/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/using/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/http/cookies/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/storage_access_api/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/hasstorageaccess/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccess/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccess/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * Update files/en-us/web/api/document/requeststorageaccessfor/index.md Co-authored-by: Jean-Yves Perrier <[email protected]> * responding to the rest of teoli2003s comments * Add RWS well-known file and security information --------- Co-authored-by: Chris Fredrickson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Perrier <[email protected]>
Description
#30500 contains the engineering technical review for my work on Storage Access API and related website sets docs, which has been completed and approved. Thank you to @cfredric and @tunetheweb for your thorough and detailed review work.
This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.
Background information
Related website sets is a part of Chrome's privacy sandbox project. It provides progressive enhancement for The Storage Access API, allowing the definition of a set of related, trusted sites that can receive automatic permission to access third party cookies originating from the set.
This PR aims to do the following:
Document.requestStorageAccessFor()
method and add mentions and links in appropriate placestop-level-storage-access
permission feature name specific torequestStorageAccessFor()
, and make sure thestorage-access
feature is marked as supported in Fx.Motivation
Additional details
Related issues and pull requests