Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial review: Topics API docs #30107

Merged
merged 49 commits into from
Feb 22, 2024
Merged

Conversation

chrisdavidmills
Copy link
Contributor

Description

#28196 contains the engineering technical review for my work on Topics API docs, which has been completed and approved. Thank you to @samdutton for your thorough and detailed review work.

This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.


Background information

The Topics API is an integral part of Google's privacy sandbox technologies. Many parts of this set are being made available by default in Chrome 115 (depending on a gradual ramp up to 100% of userbase over the 115 release period).

This PR provides documentation for the Topics API and its related HTTP headers and HTTP features.

See my research document for more details of exactly what changes are expected in the PR.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners November 8, 2023 11:35
@chrisdavidmills chrisdavidmills removed the request for review from a team November 8, 2023 11:35
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Dec 20, 2023
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jan 5, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Feb 10, 2024
@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed merge conflicts 🚧 [PR only] labels Feb 11, 2024
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty great. I thought it was a lot more understandable, nice work.

files/en-us/web/api/topics_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/using/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/using/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/browsingtopics/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/topics_api/using/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/browsingtopics/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wbamberg wbamberg merged commit b8282f9 into mdn:main Feb 22, 2024
10 checks passed
@chrisdavidmills chrisdavidmills deleted the topics-api branch February 23, 2024 09:27
@chrisdavidmills
Copy link
Contributor Author

Yay, thanks @wbamberg!

@samdutton
Copy link

samdutton commented Feb 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants