Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add WorkerGlobalScope.rejectionhandled and WorkerGlobalScope.unhandledrejection #30006

Merged
merged 4 commits into from
Nov 7, 2023
Merged

add WorkerGlobalScope.rejectionhandled and WorkerGlobalScope.unhandledrejection #30006

merged 4 commits into from
Nov 7, 2023

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 3, 2023 •
edited
Loading

Description

Motivation

Additional details

related with https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface

Related issues and pull requests

Fixes #29869

Relates with mdn/browser-compat-data#21147

@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 3, 2023
@skyclouds2001 skyclouds2001 changed the title add add WorkerGlobalScope.rejectionhandled and WorkerGlobalScope.unhandledrejection Nov 3, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/API/WorkerGlobalScope/unhandledrejection_event
Title: WorkerGlobalScope: unhandledrejection event
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerGlobalScope.unhandledrejection_event

URL: /en-US/docs/Web/API/WorkerGlobalScope/rejectionhandled_event
Title: WorkerGlobalScope: rejectionhandled event
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WorkerGlobalScope.rejectionhandled_event

(comment last updated: 2023-11-07 08:57:17)

@skyclouds2001 skyclouds2001 mentioned this pull request Nov 3, 2023
Merged
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 7, 2023 07:29
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 7, 2023 07:29
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team November 7, 2023 07:29
teoli2003
teoli2003 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nit! Thank you!

files/en-us/web/api/workerglobalscope/rejectionhandled_event/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/workerglobalscope/rejectionhandled_event/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/workerglobalscope/unhandledrejection_event/index.md Outdated Show resolved Hide resolved
@teoli2003 teoli2003 merged commit 7723224 into mdn:main Nov 7, 2023
7 checks passed
@skyclouds2001 skyclouds2001 deleted the WorkerGlobalScope-promise-rejection branch November 7, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing documentation of WorkerGlobalScope.rejectionhandled and WorkerGlobalScope.unhandledrejection
2 participants
@skyclouds2001 @teoli2003