Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(MDN): remove TenthCampaignQuote macro #29904

Merged
merged 1 commit into from
Oct 30, 2023
Merged

chore(MDN): remove TenthCampaignQuote macro #29904

merged 1 commit into from
Oct 30, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 30, 2023 •
edited
Loading

Description

Removes the invocation of the {{TenthCampaignQuote}} macro.

Motivation

We want to remove it from yari, because it causes non-deterministic build results, and the page has very few users.

Additional details

Related issues and pull requests

Relates to:

@caugner caugner requested a review from a team as a code owner October 30, 2023 12:14
@caugner caugner requested review from hamishwillee and removed request for a team October 30, 2023 12:14
@github-actions github-actions bot added the Content:Meta Content in the meta docs label Oct 30, 2023
@github-actions
Copy link
Contributor

Preview URLs

This was referenced Oct 30, 2023
Merged
Merged
@bsmth bsmth self-requested a review October 30, 2023 12:22
bsmth
bsmth approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏻

@caugner caugner merged commit 633b733 into mdn:main Oct 30, 2023
@caugner caugner deleted the remove-tenth-campaign-quote-macro branch October 30, 2023 13:05
@hamishwillee
Copy link
Collaborator

Awesome!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsmth bsmth bsmth approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Meta Content in the meta docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caugner @hamishwillee @bsmth