-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServiceWorkerGlobalScope.serviceWorker
#29461
Conversation
Preview URLs
(comment last updated: 2023-12-18 00:09:07) |
Flyby comment,
|
For I, I think as it is a simple getter, maybe it is not quite necessary to provide an example Also, as For II, I'll create another pull request to add the additonal content to @hamishwillee your idea? |
I've had reviewers ask for this of me because readers like to see an example - it makes copy-paste easy and confirms that the code to use the API will indeed be what they think it is. As a fly-by reviewer I'm explicitly removing myself as the person that places requirements on you - I'm just adding comments. BUT, if you do add an example it should be done in this PR and so should the ServiceWorker docs - either it is related an important and it should be done as the same work, or it isn't and can be ignored for the PR. But creating another PR just increases the chance it doesn't get done. |
files/en-us/web/api/serviceworkerglobalscope/registration/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/serviceworkerglobalscope/serviceworker/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
As #29451 seems to not be working, that issue will fix in this pull request |
Thanks for your suggestion! |
@wbamberg If you don't look this week I will try to next week. |
files/en-us/web/api/serviceworkerglobalscope/serviceworker/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/serviceworkerglobalscope/registration/index.md
Outdated
Show resolved
Hide resolved
cc @hamishwillee would you please review this if available |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
files/en-us/web/api/serviceworkerglobalscope/registration/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/serviceworkerglobalscope/serviceworker/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/serviceworkerglobalscope/serviceworker/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skyclouds2001 . I removed the Syntax sections - not used as that is "Value" for properties. Decided you were right - we can live without an example for a trivial getter. Merging.
PS Sorry for the delay. Finally! |
* Update index.md * Create index.md * Update index.md * Update index.md * Update index.md * Update index.md * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update index.md * Update index.md * Update index.md * Update index.md * Apply suggestions from code review * fix * Apply suggestions from code review * Update files/en-us/web/api/serviceworkerglobalscope/clients/index.md * Update files/en-us/web/api/serviceworker/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/api/serviceworkerglobalscope/registration/index.md * Update files/en-us/web/api/serviceworkerglobalscope/serviceworker/index.md * Update files/en-us/web/api/serviceworkerglobalscope/serviceworker/index.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hamish Willee <[email protected]>
Description
add
ServiceWorkerGlobalScope.serviceWorker
documentationMotivation
Additional details
https://w3c.github.io/ServiceWorker/#serviceworkerglobalscope-interface
https://w3c.github.io/ServiceWorker/#service-worker-global-scope-serviceworker
Related issues and pull requests
Fixes #29123
Fixes #29541