-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): update 'drop-shadow()' page #29013
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2023-09-22 19:08:17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OnkarRuikar for adding these improvements to the page!
Co-authored-by: Dipika Bhattacharya <[email protected]>
226e39e
to
33c009f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @OnkarRuikar. It is getting pretty close. Just a few more adjustments needed for the box-shadow
page.
- `<color>` | ||
- : See {{cssxref("<color>")}} values for possible keywords and notations. | ||
If not specified, it defaults to {{cssxref("<color>","currentcolor","#currentcolor_keyword")}}. | ||
- The fourth optional {{cssxref("<length>")}} value is interpreted as `<spread-radius>`. Positive values will cause the shadow to expand and grow bigger, negative values will cause the shadow to shrink. If not specified, it will be `0` (the shadow will be the same size as the element). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The fourth optional {{cssxref("<length>")}} value is interpreted as `<spread-radius>`. Positive values will cause the shadow to expand and grow bigger, negative values will cause the shadow to shrink. If not specified, it will be `0` (the shadow will be the same size as the element). | |
- If four values are specified, the fourth value is interpreted as `<spread-radius>`. Positive values will cause the shadow to expand and grow bigger, negative values will cause the shadow to shrink. If not specified, it will be set to `0` (that is, the shadow will be the same size as the element). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're updating the value descriptions, can we also update this part just before "Values" to remove duplicate info:
Specify a single box-shadow using:
- Two, three, or four
<length>
values.
- If only two values are given, they are interpreted as
<offset-x>
and<offset-y>
values.- If a third value is given, it is interpreted as a
<blur-radius>
.- If a fourth value is given, it is interpreted as a
<spread-radius>
.- Optionally, the
inset
keyword.- Optionally, a
<color>
value.To specify multiple shadows, provide a comma-separated list of shadows.
- We should probably move the above text to the "Values" section.
- And update it to:
You can create a single box-shadow by specifying two, three, or four
<length>
values, an optionalinset
, and an optional<color>
value. To create multiple box-shadows, specify a comma-separated list of shadows for thebox-shadow
property.
Co-authored-by: Dipika Bhattacharya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on these update, @OnkarRuikar 🙌
It is helpful to document the required parameters first then the optional parameters. For usage in code no guideline exist about the order. Also Prettier has no opinion about this. We can show all allowed combinations of values in the "Syntax" section.
The PR does following changes:
{{optional_inline}}
badge. All non optional params are mandatory.