Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent formatting for all macros #29006

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

Josh-Cena
Copy link
Member

Description

As part of my see-also checker work, I have found a way to parse macros so I can check for consistent macro text. In this process I found it better to make all macros uniform. This PR makes macro text conform to Prettier style as well, and uses consistent casing for all macros.

Motivation

Additional details

Related issues and pull requests

@Josh-Cena Josh-Cena requested a review from a team as a code owner September 8, 2023 23:34
@Josh-Cena Josh-Cena requested review from Elchi3 and removed request for a team September 8, 2023 23:34
@github-actions github-actions bot added the Content:JS JavaScript docs label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Preview URLs (79 pages)
External URLs (2)

URL: /en-US/docs/Web/JavaScript/Reference/Lexical_grammar
Title: Lexical grammar

@hamishwillee
Copy link
Collaborator

#29008 (comment)

@Josh-Cena Josh-Cena requested review from hamishwillee and removed request for Elchi3 September 12, 2023 03:31
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but as discussed in https://github.com/orgs/mdn/discussions/448 it's at "own risk" that you might have to change some of these again.

@hamishwillee hamishwillee merged commit 4f86aad into mdn:main Sep 12, 2023
5 checks passed
@Josh-Cena Josh-Cena deleted the format-macro branch September 12, 2023 04:14
mfuji09 pushed a commit to mfuji09/MDN-content that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants