Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check in a cspell config file #28487

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Aug 10, 2023

Description

This PR gets a basic cspell config checked in that we can start using in our IDEs and on the CLI. This will not cover everything and allow us to spellcheck the entire repo from the beginning, but we can improve / use it as we go along.

Motivation

Adding en-US as preferred dictionary. Incrementally adding project words that may open the door to CI in the long term.

Related issues and pull requests

#12522

CC @nschonni

@bsmth bsmth requested a review from a team as a code owner August 10, 2023 09:24
@bsmth bsmth requested review from dipikabh and removed request for a team August 10, 2023 09:24
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Aug 10, 2023
@dipikabh
Copy link
Contributor

Making a note that @bsmth has also opened a discussion around this topic: https://github.com/orgs/mdn/discussions/437

I am okay with this PR with the context and caveats recorded in the discussion. Let's land this after a no-objection in Monday's Editorial.

@nschonni
Copy link
Contributor

You may want to skip adding in the NPM dependency and script target, but you may want to add the suggested extension in https://github.com/mdn/content/blob/main/.vscode/extensions.json as part of t his first pass

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this, @bsmth 👍. Let's land this and see how it rolls.
(Note: there's no comment in the discussion or from Editorial at this point)

@dipikabh dipikabh merged commit 93e31f6 into mdn:main Aug 16, 2023
6 checks passed
@bsmth bsmth deleted the 12522-add-cspell-config branch August 28, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants