Added possible values for table frame attribute #28399
Conversation
Added possible values for frame attribute
EzioMercer
changed the title
|
Thank you for the contribution. The Here is content that may be helpful for your students: Styling tables: Marking up tables: |
|
you have a very valid point. We should create an issue to determine whether we should be adding all the deprecated enumerated values that are missing (your PR), or removing the deprecated values that should not be used in favor of using CSS. The CSS comments are there, which is good, but unclear why we are including enumerated values for some deprecated attributes but not others. |
|
Let's also change This enumerated attribute defines where rules, i.e. lines, should appear in a table. Lines can be set to appear between `rows`, `cols` (for columns), or `groups` (between `<thead>`, `<tbody>`, and `<tfoot>` elements, and between `<col>` and `<colgroup>` elements), or `all` or `none` of the above. |
|
Preview URLs (comment last updated: 2024-01-12 13:26:00) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@estelle Can you please help me? I can't understand how to update the PR preview page. I made changes which you asked but can't see the result |
| - : This enumerated attribute defines which side of the frame surrounding the table must be displayed. It can have the following values: | ||
|
|
||
| - `void`, which indicates that no sides will be displayed; it is the default value; | ||
| - `above`, which indicates that the top side only will be displayed; | ||
| - `below`, which indicates that the bottom side only will be displayed; | ||
| - `hsides`, which indicates that the top and bottom sides only will be displayed; | ||
| - `vsides`, which indicates that the right and left sides only will be displayed; | ||
| - `lhs`, which indicates that the left-hand side only will be displayed; | ||
| - `rhs`, which indicates that the right-hand side only will be displayed; | ||
| - `box`, which indicates that the all four sides will be displayed; | ||
| - `border`, which indicates that the all four sides will be displayed; it is same as `box`; |
There was a problem hiding this comment.
| - : This enumerated attribute defines which side of the frame surrounding the table must be displayed. It can have the following values: | |
| - `void`, which indicates that no sides will be displayed; it is the default value; | |
| - `above`, which indicates that the top side only will be displayed; | |
| - `below`, which indicates that the bottom side only will be displayed; | |
| - `hsides`, which indicates that the top and bottom sides only will be displayed; | |
| - `vsides`, which indicates that the right and left sides only will be displayed; | |
| - `lhs`, which indicates that the left-hand side only will be displayed; | |
| - `rhs`, which indicates that the right-hand side only will be displayed; | |
| - `box`, which indicates that the all four sides will be displayed; | |
| - `border`, which indicates that the all four sides will be displayed; it is same as `box`; | |
| - : This enumerated attribute specifies which outer sides of the table should have borders drawn. The default `void` means no borders. The `above`, `below`, `lhs` (left-hand side), and `rhs` (right-hand side) lead to a border on a single side. Two sides will have borders with `hsides` (horizontal sides), `vsides` (vertical sides). All four sides will have a border if `box` or `border` is set. The CSS {{cssxref("border-style")}} property, set on the table, supersedes borders set by this HTML attribute. |
| - `rows`, which will cause the rules to be displayed between rows; | ||
| - `cols`, which will cause the rules to be displayed between columns; | ||
| - `all`, which will cause the rules to be displayed between rows and columns. | ||
| - : This enumerated attribute defines where rules, i.e. lines, should appear in a table. Lines can be set to appear between `rows`, `cols` (for columns), or `groups` (between `<thead>`, `<tbody>`, and `<tfoot>` elements, and between `<col>` and `<colgroup>` elements), or `all` or `none` of the above. |
There was a problem hiding this comment.
| - : This enumerated attribute defines where rules, i.e. lines, should appear in a table. Lines can be set to appear between `rows`, `cols` (for columns), or `groups` (between `<thead>`, `<tbody>`, and `<tfoot>` elements, and between `<col>` and `<colgroup>` elements), or `all` or `none` of the above. | |
| - : This enumerated attribute defines where rules, i.e. lines, should appear in a table. Lines can be set to appear between `rows`, `cols` (for columns), or `groups` (between `<thead>`, `<tbody>`, and `<tfoot>` elements, and between `<col>` and `<colgroup>` elements), or `all` or `none` of the above. CSS {{cssxref("border-style")}} supersedes borders set by this attribute. |
https://pr28399.content.dev.mdn.mozit.cloud/en-US/docs/Web/HTML/Element/table the preview feature was down for a few days, so maybe it wasn't showing, but generally search in this page for "Preview URLs" and it should direct you to the github action creating a preview link |
|
@estelle Yes I know about that links but I can't understand how to update them and/or when do they updates automatically? As you can see here I already made changes for
So I'm a little confused. I thought that this page will update after each commit |
|
Hi @EzioMercer - there are some review comments above waiting on you. Do you plan to come back to this one? |
|
Hi @bsmth! Of course I will, I'm waiting the response to my last question. I can't update the preview link to see how my last changes look like |
I understand 👍🏻. You can check this sticky comment: #28399 (comment) - It should have the latest changes from this branch. I can see your proposed changes there as expected. |
|
It looks like this PR has stalled. What's next steps here @EzioMercer and @estelle? |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
Hi both 👋🏻 I am going to close this one as it's stalled with conflicts & suggestions etc., additionally with the context of adding more info to deprecated features when there are suggested alternatives, I don't think we need to keep improving this section. Thank you! :) |
Added possible values for table frame attribute
Possible values were missed so I added them
I'm Frontend teacher and I always try to use MDN Web Docs to show my students any information. When I tried to find possible values of
frameattribute I had to go to other web pages. I think it will be great if all need information will be in MDN Web Docs and my students will see that they always can use this documentationDocs where I got the information from