Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebAssembly | Memory - add note about allocation failure #27017

Merged
merged 9 commits into from Jun 5, 2023
Merged

WebAssembly | Memory - add note about allocation failure #27017

merged 9 commits into from Jun 5, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2023

Description

Allocating WebAssembly.Memory is allowed to sporadically fail should the UA decide to do so or be unable to do so, as per the specification.

Motivation

It conveys the error that may occur if the existing described cases do not apply.

Additional details

From https://webassembly.github.io/spec/js-api/#dom-memory-memory.

@github-actions github-actions bot added the Content:wasm WebAssembly docs label May 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-05-31 14:08:22)

@ghost ghost marked this pull request as ready for review May 28, 2023 18:52
@ghost ghost self-requested a review as a code owner May 28, 2023 18:52
@ghost ghost requested review from bsmth and removed request for a team May 28, 2023 18:52
@ghost ghost mentioned this pull request May 28, 2023
Merged
wbamberg
wbamberg approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yes, this looks a lot better, thank you @phosra ! Approving, but not merging because this has Prettier errors. Would you be able to fix them? I'm sorry about our rather contributor-hostile CI :(.

@ghost
Copy link
Author

ghost commented May 30, 2023

👍 yes, this looks a lot better, thank you @phosra ! Approving, but not merging because this has Prettier errors. Would you be able to fix them? I'm sorry about our rather contributor-hostile CI :(.

Unfortunately for myself (I had to mention it elsewhere too #27018 (comment)), I don't have a simple means of doing so on my local system. May I have any suggestions from yourself?

@wbamberg
Copy link
Collaborator

👍 yes, this looks a lot better, thank you @phosra ! Approving, but not merging because this has Prettier errors. Would you be able to fix them? I'm sorry about our rather contributor-hostile CI :(.

Unfortunately for myself (I had to mention it elsewhere too #27018 (comment)), I don't have a simple means of doing so on my local system. May I have any suggestions from yourself?

I'm asking the other maintainers if we can change the way we do this, as it is (to me) a systemic issue. So we'll have to see what happens. Maybe some other helpful person will fix your PR in the meantime (but the systemic issue will remain).

@Josh-Cena
Copy link
Member

@phosra @wbamberg The trick is to paste the entire file into https://prettier.io/playground and paste the result back.

@bsmth bsmth mentioned this pull request May 31, 2023
Merged
@bsmth
Copy link
Member

bsmth commented Jun 5, 2023

Thanks all, merging shortly as everything looks ready to go 👍🏻

@bsmth bsmth merged commit 9c1ccaf into mdn:main Jun 5, 2023
@ghost ghost deleted the patch-3 branch June 6, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth Awaiting requested review from bsmth bsmth is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:wasm WebAssembly docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbamberg @Josh-Cena @bsmth