fix: slugs and titles in CSS module landing pages (f-s) #26958

dipikabh · 2023-05-25T02:59:00Z

Description

This is the second in the series after #26939.

github-actions · 2023-05-25T03:03:36Z

Preview URLs (42 pages)

Flaws (16)

Note! 31 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_overflow
Title: CSS overflow
Flaw count: 5

macros:
- /en-US/docs/Web/CSS/block-ellipsis does not exist
- /en-US/docs/Web/CSS/continue does not exist
- /en-US/docs/Web/CSS/line-clamp does not exist
- /en-US/docs/Web/CSS/max-lines does not exist
broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSSOM_View

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grid_layout_and_accessibility
Title: Grid layout and accessibility
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Relationship_of_grid_layout_with_other_layout_methods
Title: Relationship of grid layout to other layout methods
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_Columns

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grid_layout_and_progressive_enhancement
Title: CSS Grid Layout and progressive enhancement
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Realizing_common_layouts_using_grids
Title: Realizing common layouts using grids
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/CSS/Media_Queries
- Can't resolve /en-US/docs/Web/CSS/Media_Queries

URL: /en-US/docs/Web/CSS/CSS_masking
Title: CSS masking
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/clip-rule does not exist

URL: /en-US/docs/Web/CSS/CSS_flow_layout
Title: CSS flow layout
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_Writing_Modes

URL: /en-US/docs/Web/CSS/CSS_flow_layout/Introduction_to_formatting_contexts
Title: Introduction to formatting contexts
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_Columns/Basic_Concepts_of_Multicol

URL: /en-US/docs/Web/CSS/CSS_flow_layout/Flow_layout_and_writing_modes
Title: Flow layout and writing modes
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_Writing_Modes

URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values
Title: CSS logical properties and values
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_Writing_Modes

URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values/Floating_and_positioning
Title: Logical properties for floating and positioning
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_Positioning

External URLs (13)

URL: /en-US/docs/Web/CSS/CSS_scroll_snap/Basic_concepts
Title: Basic concepts of scroll snap

https://12daysofweb.dev/2022/css-scroll-snap/ (1 time) (Note! This may be a new URL 👀)
https://codepen.io/collection/KpqBGW (1 time) (Note! This may be a new URL 👀)
https://css-tricks.com/practical-css-scroll-snapping/ (1 time) (Note! This may be a new URL 👀)
https://web.dev/css-scroll-snap/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grid_layout_using_line-based_placement
Title: Grid layout using line-based placement

https://firefox-source-docs.mozilla.org/devtools-user/page_inspector/how_to/examine_grid_layouts/index.html (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Realizing_common_layouts_using_grids
Title: Realizing common layouts using grids

https://css-tricks.com/snippets/css/complete-guide-grid/ (1 time) (Note! This may be a new URL 👀)
https://gridbyexample.com (1 time) (Note! This may be a new URL 👀)
https://www.quackit.com/css/grid/examples/css_grid_website_layout_examples.cfm (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Box_alignment_in_grid_layout
Title: Box alignment in grid layout

https://drafts.csswg.org/css-align/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Grids_logical_values_and_writing_modes
Title: Grids, logical values, and writing modes

https://drafts.csswg.org/css-logical/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/CSS/CSS_flow_layout/Flow_layout_and_writing_modes
Title: Flow layout and writing modes

https://24ways.org/2016/css-writing-modes/ (1 time) (Note! This may be a new URL 👀)
https://www.smashingmagazine.com/2019/08/writing-modes-layout/ (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Web/CSS/CSS_logical_properties_and_values/Basic_concepts_of_logical_properties_and_values
Title: Basic concepts of logical properties and values

https://www.smashingmagazine.com/2018/03/understanding-logical-properties-values/ (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2023-05-29 08:35:55)

github-actions · 2023-05-25T23:49:24Z

This pull request has merge conflicts that must be resolved before it can be merged.

- letters g and i module landing pages - letter l module landing page - letter f module landing page - letter m module landing pages - letters n, o, p module landing pages - letters r and s module landing pages - fix broken links - fix broken links

estelle · 2023-05-27T00:05:58Z

@dipikabh there's an issue:

error: _redirects.txt for en-us is causing issues: Error: Invalid redirect for /en-US/docs/Web/CSS/CSS_Positioning -> /en-US/docs/Web/CSS/CSS_positioned_layout or /en-US/docs/Web/CSS/CSS_Pages -> /en-US/docs/Web/CSS/CSS_paged_media

dipikabh · 2023-05-29T01:09:32Z

@dipikabh there's an issue:

error: _redirects.txt for en-us is causing issues: Error: Invalid redirect for /en-US/docs/Web/CSS/CSS_Positioning -> /en-US/docs/Web/CSS/CSS_positioned_layout or /en-US/docs/Web/CSS/CSS_Pages -> /en-US/docs/Web/CSS/CSS_paged_media

Yes, after I resolved the conflicts in the redirects and wikihistory files on Friday, I saw these redirects issue and so didn't proceed with the merge. I tested both those redirects locally and they're both working in my local preview, so I am not sure what the issue is. I was hoping to get some help from engineering but Monday is a bank holiday.

I am inclined to merge this anyway since the error is not blocking the merging, lest the branch goes stale.

caugner · 2023-05-29T08:37:32Z

FWIW @dipikabh Running yarn content fix-redirects fixed it. The cause of the error was that the redirects file was no longer alphabetically ordered after resolving the merge conflicts, see c89c4d0.

dipikabh · 2023-05-29T16:44:13Z

Thanks a lot @caugner for troubleshooting and fixing this! 🙏

ref: mdn/content#26958

* zh-tw: sync translated content * fix: slugs and titles in CSS module landing pages (f-s) ref: mdn/content#26958 --------- Co-authored-by: allo <[email protected]>

ref: mdn/content#26958

* zh-cn: sync translated content * fix: slugs and titles in CSS module landing pages (f-s) ref: mdn/content#26958 * remove old sidebar sections --------- Co-authored-by: allo <[email protected]>

dipikabh requested review from a team as code owners May 25, 2023 02:59

dipikabh requested review from chrisdavidmills and removed request for a team May 25, 2023 02:59

github-actions bot added the Content:CSS Cascading Style Sheets docs label May 25, 2023

dipikabh mentioned this pull request May 25, 2023

fix: slugs and titles in CSS module landing pages (a-f) #26939

Merged

dipikabh requested review from estelle and teoli2003 and removed request for a team May 25, 2023 03:25

dipikabh mentioned this pull request May 25, 2023

fix: slugs and titles in CSS module landing pages (m - v plus misc) #26974

Merged

github-actions bot added the merge conflicts 🚧 [PR only] label May 25, 2023

estelle approved these changes May 25, 2023

View reviewed changes

update slugs

a56e399

- letters g and i module landing pages - letter l module landing page - letter f module landing page - letter m module landing pages - letters n, o, p module landing pages - letters r and s module landing pages - fix broken links - fix broken links

dipikabh force-pushed the css-modland-slug-title-g branch from 6b1745c to a56e399 Compare May 26, 2023 17:12

github-actions bot removed the merge conflicts 🚧 [PR only] label May 26, 2023

fix(redirects): sort

c89c4d0

caugner merged commit f79a491 into mdn:main May 29, 2023

yin1999 added a commit to mdn/translated-content that referenced this pull request May 30, 2023

fix: slugs and titles in CSS module landing pages (f-s)

b4be915

ref: mdn/content#26958

yin1999 added a commit to mdn/translated-content that referenced this pull request May 30, 2023

fix: slugs and titles in CSS module landing pages (f-s)

fe52029

ref: mdn/content#26958

caugner mentioned this pull request Jul 17, 2023

fix(macros/CSSRef): Update links to the pages they redirect to mdn/yari#9307

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: slugs and titles in CSS module landing pages (f-s) #26958

fix: slugs and titles in CSS module landing pages (f-s) #26958

dipikabh commented May 25, 2023

github-actions bot commented May 25, 2023 •

edited

Loading

github-actions bot commented May 25, 2023

estelle commented May 27, 2023

dipikabh commented May 29, 2023

caugner commented May 29, 2023

dipikabh commented May 29, 2023

fix: slugs and titles in CSS module landing pages (f-s) #26958

fix: slugs and titles in CSS module landing pages (f-s) #26958

Conversation

dipikabh commented May 25, 2023

Description

github-actions bot commented May 25, 2023 • edited Loading

github-actions bot commented May 25, 2023

estelle commented May 27, 2023

dipikabh commented May 29, 2023

caugner commented May 29, 2023

dipikabh commented May 29, 2023

github-actions bot commented May 25, 2023 •

edited

Loading