Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: move block-level and inline-level pages from HTML to CSS #25891

Merged
merged 15 commits into from
May 10, 2023
Merged

CSS: move block-level and inline-level pages from HTML to CSS #25891

merged 15 commits into from
May 10, 2023

Conversation

OnkarRuikar
Copy link
Contributor

Addresses: https://github.com/orgs/mdn/discussions/353#discussioncomment-5491423

As HTML5 uses a new classification now(content categories), the PR removes Inline_elements and Block-level_elements pages from HTML tree. And adds block-level and inline-level glossary pages as CSS concepts.

@OnkarRuikar OnkarRuikar requested review from a team as code owners April 4, 2023 02:56
@OnkarRuikar OnkarRuikar requested review from sideshowbarker, schalkneethling and estelle and removed request for a team April 4, 2023 02:56
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:WebAPI Web API docs labels Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

Preview URLs (16 pages)
Flaws (2)

Note! 15 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Text_fragments
Title: Text fragments
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
External URLs (1)

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Getting_started
Title: Getting started with HTML

(comment last updated: 2023-05-10 06:23:42)

teoli2003
teoli2003 reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I made a few drive-by comments; this still need a thorough review by a SME)

@sideshowbarker sideshowbarker removed their request for review April 4, 2023 12:05
@OnkarRuikar OnkarRuikar force-pushed the inline_block branch 2 times, most recently from 151e92f to 35ba3ca Compare April 5, 2023 02:37
@OnkarRuikar
Copy link
Contributor Author

Ping @dipikabh @estelle

This was referenced Apr 5, 2023
Merged
Closed
@OnkarRuikar
Copy link
Contributor Author

Would be great if we merge this. This was the 4th conflict resolution. 😞
We already have an approval from the code owner (the flag got unset after rebase).

estelle
estelle reviewed May 9, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested changing all the inline elements to inline-level elements, and a few other suggestions

files/en-us/glossary/inline-level_content/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/inline-level_content/index.md Outdated Show resolved Hide resolved
files/en-us/learn/html/introduction_to_html/getting_started/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/column-span/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/element/getclientrects/index.md Outdated Show resolved Hide resolved
files/en-us/learn/css/css_layout/normal_flow/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/span/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/vertical-align/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/index.md Outdated Show resolved Hide resolved
OnkarRuikar and others added 14 commits May 10, 2023 11:33
@OnkarRuikar
CSS: move block-level and inline-level pages from HTML to CSS
9473dac 
Addresses: https://github.com/orgs/mdn/discussions/353#discussioncomment-5491423

As HTML5 uses a new classification now, the PR removes Inline_elements and Block-level_elements pages from HTML tree.

 And adds `block-level` and `inline-level` glossary pages as CSS concepts.
@OnkarRuikar
remove a redundant redirect
5e93388
@OnkarRuikar
Apply review comments
6a5ec34
@OnkarRuikar @yarusome
Apply suggestions from code review
f5fa720 
Co-authored-by: yarusome <[email protected]>
@OnkarRuikar
Add a note about writing mode
da0b324
@OnkarRuikar @estelle
Apply suggestions from code review
7e33721 
Co-authored-by: Estelle Weyl <[email protected]>
@OnkarRuikar @estelle
Apply suggestions from code review
87df1c0 
Co-authored-by: Estelle Weyl <[email protected]>
@OnkarRuikar
make content catiegories section small
dfb4832
@OnkarRuikar
fix flaws
5bc386a
@OnkarRuikar
add a link to replaced elments
efe9f2f
@OnkarRuikar @estelle
Apply suggestions from code review
a5048e7 
Co-authored-by: Estelle Weyl <[email protected]>
@OnkarRuikar
Update files/en-us/glossary/inline-level_content/index.md
6afb6a7
@OnkarRuikar
Remove content category section from HTML intro
8155455
@OnkarRuikar
Fix lint error
0f68222
@OnkarRuikar OnkarRuikar requested a review from estelle May 10, 2023 06:04
estelle
estelle approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

I checked the HTML4. spec. It reads as "Block-level" and "inline", without the "block", so I changed only the two historical references to inline without the "-level".

Thank you for all you do!

files/en-us/glossary/block-level_content/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/inline-level_content/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flow_layout/block_and_inline_layout_in_normal_flow/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/index.md Outdated Show resolved Hide resolved
@estelle estelle merged commit a46d4d1 into mdn:main May 10, 2023
@OnkarRuikar OnkarRuikar deleted the inline_block branch May 10, 2023 06:22
@OnkarRuikar
Copy link
Contributor Author

Yey! 🎉

I checked the HTML4. spec. It reads as "Block-level" and "inline", without the "block", so I changed only the two historical references to inline without the "-level".

So when an element like span is inline by default, should it be referred to as inline or inline-level?
Has the term inline been changed to the broader version inline-level now?

@estelle
Copy link
Member

estelle commented May 10, 2023

Elements, according to the HTML 4 specification, used to be either block-level or inline. That was it. No other categories i don't think. The new specification uses neither inline not inline-level. Rather, it uses content models, https://html.spec.whatwg.org/#kinds-of-content.

Using inline-level is not an official term. inliine is not correct, whereas inline-level makes it match block-level.

This was referenced May 11, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 left review comments

@yarusome yarusome yarusome left review comments

@estelle estelle estelle approved these changes

@schalkneethling schalkneethling Awaiting requested review from schalkneethling schalkneethling is a code owner automatically assigned from mdn/yari-content-html

Assignees

@estelle estelle

@OnkarRuikar OnkarRuikar

Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OnkarRuikar @estelle @teoli2003 @yarusome