Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-code formal syntax #25327

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Hard-code formal syntax #25327

merged 2 commits into from
Mar 14, 2023

Conversation

dawei-wang
Copy link
Contributor

Fix #25321

Description

Motivation

Additional details

Related issues and pull requests

@dawei-wang dawei-wang requested a review from a team as a code owner March 14, 2023 20:44
@dawei-wang dawei-wang requested review from estelle and removed request for a team March 14, 2023 20:44
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

Preview URLs

(comment last updated: 2023-03-14 22:56:25)

@wbamberg
Copy link
Collaborator

Sorry @dawei-wang , I misspoke in #25321 (comment). I think we ought to hardcode formal syntax here, as we do for other nonstandard properties like https://developer.mozilla.org/en-US/docs/Web/CSS/box-orient#formal_syntax.

In this case we can find the hardcoded value to use in mdn/data: https://github.com/mdn/data/blob/955b7113e3fea6026df1ed38565cca2d0146a608/css/properties.json#L937.

@dawei-wang dawei-wang changed the title Remove formal syntax Hard-code formal syntax Mar 14, 2023
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @dawei-wang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: could not find syntax for this item with {{csssyntax}}
2 participants