Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'How to add tags' page #25131

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

teoli2003
Copy link
Contributor

Now that tags are gone, this page is no more useful.

@teoli2003 teoli2003 requested a review from a team as a code owner March 7, 2023 06:29
@teoli2003 teoli2003 requested review from hamishwillee and removed request for a team March 7, 2023 06:29
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Mar 7, 2023
@teoli2003
Copy link
Contributor Author

This fixes the last content bit of mdn/mdn#262

@OnkarRuikar
Copy link
Contributor

We need to remove links to the page as well:

[`tags`]: https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Howto/Tag

[`Deprecated`](/en-US/docs/MDN/Writing_guidelines/Howto/Tag#technology_status_tags)

See [How to tag pages](/en-US/docs/MDN/Writing_guidelines/Howto/Tag) for information about which tags to apply.

See [How to properly tag pages](/en-US/docs/MDN/Writing_guidelines/Howto/Tag)

@teoli2003 teoli2003 requested a review from a team as a code owner March 8, 2023 06:04
@teoli2003 teoli2003 requested review from bsmth and removed request for a team March 8, 2023 06:04
@teoli2003
Copy link
Contributor Author

teoli2003 commented Mar 8, 2023

Good point. My brain malfunctioned and believed there would be no links to it… This is obviously not the case.

@OnkarRuikar
Copy link
Contributor

OnkarRuikar commented Mar 8, 2023

and believed there would be no links to it… This is obviously not the case.

The onus shouldn't be put on contributors to remember these auto detectable things. It would be better if the PR check workflow, for every deleted document in the PR, grep(rg) entire content for links(/en-US/docs/${docPath}).

Or may be the document deletion script, after deletion, warn/log document containing references to the deleted document.

@teoli2003
Copy link
Contributor Author

Or may be the document deletion script, after deletion, warn/log document containing references to the deleted document.

I think that yarn content move should fix Markdown links automatically. (I opened a yari issue for this: mdn/yari#8292 – the yari team signaled in it that they are accepting PRs for it)
and yarn content delete should list Markdown links to the deleted document so that the editor doesn't forget to edit them. (No yari issue opened for this yet)

Even if it doesn't work for links generated by macros, it will already solve many cases.

@hamishwillee
Copy link
Collaborator

The fact is, even if you add a redirect, that does not clean up the content around the page link. The redirect should really only be to fix up external links to the page, for which we have no control. I'm sure we all agree with that, and the need to clean up content when deleting/redirecting.

Sadly, I once proposed that deleting or moving a page should list the linked pages. That got closed by (as I recall) a warning added when you delete or redirect a page that you might need to do cleanup. We could request this in yari again.

Thanks very much for making this fix @teoli2003 !!!

@hamishwillee
Copy link
Collaborator

PS I think it might be worth having a single page covering page metadata, and sticking as much of our page metadata instructions elsewhere into that.

@hamishwillee hamishwillee merged commit 4ae3910 into mdn:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants