Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page type: glossary-definition (part5) #23602

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Page type: glossary-definition (part5) #23602

merged 2 commits into from
Jan 17, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 13, 2023 •
edited
Loading

stragglers that have parenthesis in the name and are breaking the build

@estelle estelle requested a review from a team as a code owner January 13, 2023 04:55
@estelle estelle requested review from bsmth and removed request for a team January 13, 2023 04:55
@github-actions github-actions bot added the Content:Glossary Glossary entries label Jan 13, 2023
@estelle estelle marked this pull request as draft January 13, 2023 06:07
@estelle estelle marked this pull request as ready for review January 13, 2023 06:08
@bsmth
Copy link
Member

bsmth commented Jan 13, 2023

See #23605

@estelle
Copy link
Member Author

estelle commented Jan 17, 2023

should we force merge?

bsmth
bsmth approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge and address the path issues in a follow-up

@bsmth bsmth merged commit 6cc3e65 into mdn:main Jan 17, 2023
This was referenced Jan 17, 2023
Merged
Closed
@estelle estelle deleted the glossary5 branch May 24, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:Glossary Glossary entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @bsmth