-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20987 initial CSS container queries updates #22186
Conversation
Preview URLs (12 pages)
Flaws (1)Note! 11 documents with no flaws that don't need to be listed. 🎉 URL:
(this comment was updated 2022-11-14 15:48:26.887119) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the at-rule. Still working on it.
For the @container
page:
- The "descriptors" are not descriptor. They are query features.
- We're missing the
height
feature. - People don't fully understand inline and block direction, so that needs to be linked (not a give).
- The container condition is not limited to feature query; only single feature query example and syntax is shown
- The
style()
option of the container query is not discussed - Query modifiers are missing
- stringing multiple conditions with modifiers is missing
- No information is provided on the container name syntax
- a custom ident is case sensitive
- can not be a keyword that may conflict or the word
default
- can start with --, which is a different kind of ident, but i forget the name
- is not quoted
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Co-authored-by: Estelle Weyl <[email protected]>
Tracking review suggestions:
|
…987-container-queries
Thanks @estelle Note: |
This PR is a first pass for improving the documentation for CSS container queries.
I expect there to be some further follow-ups to add more details and (live/interactive) examples where necessary or other pages that I've missed here.
Highlights
Updates:
css_container_queries
most of the updates occur in this doc includinglength
: added information to this document about "container query length units" which allow you to specify a length relative to the dimensions of a query container.Additions:
@container
at-rulecontainer-name
propertycontainer-type
propertycontainer
shorthand property (simplifies container name and type to one declaration)