-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't allow FQDN links #21432
fix: don't allow FQDN links #21432
Conversation
859117b
to
e13d517
Compare
Preview URLs
Flaws (2)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
(this comment was updated 2022-11-11 11:06:47.137740) |
files/en-us/mdn/writing_guidelines/attrib_copyright_license/index.md
Outdated
Show resolved
Hide resolved
This is now complete: |
files/en-us/mdn/writing_guidelines/attrib_copyright_license/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nschonni, I think we can merge this one 👍🏻
Merging shortly |
Adds another Markdownlint Search/Replace rule to prevent
https://developer.mozilla.org
links, since they should be absolute links instead.Because the root Markdownfiles actually need the FQDN links, I swapped them to use Reference links so the regex doesn't catch them. Easier way would be a trailing Markdownlint disable comment, but those haven't been accepted in the past for other PRs, so this is the workaround