Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow FQDN links #21432

Merged
merged 10 commits into from
Nov 11, 2022
Merged

fix: don't allow FQDN links #21432

merged 10 commits into from
Nov 11, 2022

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 10, 2022

Adds another Markdownlint Search/Replace rule to prevent https://developer.mozilla.org links, since they should be absolute links instead.
Because the root Markdownfiles actually need the FQDN links, I swapped them to use Reference links so the regex doesn't catch them. Easier way would be a trailing Markdownlint disable comment, but those haven't been accepted in the past for other PRs, so this is the workaround

README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Oct 12, 2022
@nschonni nschonni marked this pull request as ready for review October 12, 2022 17:03
@nschonni nschonni requested review from a team as code owners October 12, 2022 17:03
@nschonni nschonni requested review from bsmth and sideshowbarker and removed request for a team October 12, 2022 17:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/MDN/Community/Pull_requests
Title: Pull request guidelines
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/MDN/Writing_guidelines/Attrib_copyright_license
Title: Attribution and copyright licensing
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

(this comment was updated 2022-11-11 11:06:47.137740)

@bsmth
Copy link
Member

bsmth commented Oct 13, 2022

Opening as a draft, because there are still some links in the meta/ site that are pending deletion in another PR

This is now complete:

@github-actions github-actions bot removed the Content:WebAPI Web API docs label Oct 13, 2022
@sideshowbarker sideshowbarker removed their request for review October 14, 2022 07:17
CONTRIBUTING.md Show resolved Hide resolved
.markdownlint-cli2.jsonc Outdated Show resolved Hide resolved
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nschonni, I think we can merge this one 👍🏻

@bsmth
Copy link
Member

bsmth commented Nov 11, 2022

Merging shortly

@bsmth bsmth requested a review from a team as a code owner November 11, 2022 11:03
@bsmth bsmth requested review from estelle and removed request for a team November 11, 2022 11:03
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Nov 11, 2022
@bsmth bsmth merged commit 2bd6fbb into mdn:main Nov 11, 2022
@nschonni nschonni deleted the markdownlint-fqdn branch November 11, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants