Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Prettier on JS code fences, part 7 #21215

Merged
merged 3 commits into from
Oct 1, 2022
Merged

Run Prettier on JS code fences, part 7 #21215

merged 3 commits into from
Oct 1, 2022

Conversation

OnkarRuikar
Copy link
Contributor

The PR focuses only on JS code fences.

Idea is to gradually prettify all the JS code fences before the full automation.

cc/ @Josh-Cena , @wbamberg

@OnkarRuikar OnkarRuikar requested a review from a team October 1, 2022 03:07
@OnkarRuikar OnkarRuikar requested review from a team as code owners October 1, 2022 03:07
@OnkarRuikar OnkarRuikar requested review from Elchi3 and schalkneethling and removed request for a team October 1, 2022 03:07
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Media Media docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs labels Oct 1, 2022
@OnkarRuikar
Copy link
Contributor Author

Skipped WebExtensions pages.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022 •
edited
Loading

Preview URLs (32 pages)
Flaws (32)

Note! 24 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/XSLT/XSLT_JS_interface_in_Gecko/Advanced_Example
Title: Advanced Example
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/XSLTProcessor/getParameter does not exist
    • /en-US/docs/Web/API/XSLTProcessor/setParameter does not exist

URL: /en-US/docs/Web/XSLT/XSLT_JS_interface_in_Gecko/JavaScript_XSLT_Bindings
Title: JavaScript/XSLT Bindings
Flaw count: 8

  • macros:
    • /en-US/docs/Web/API/XSLTProcessor/importStylesheet does not exist
    • /en-US/docs/Web/API/XSLTProcessor/importStylesheet does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToDocument does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToFragment does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToDocument does not exist
    • and 2 more flaws omitted
  • heading_links:
    • h3 heading contains an <a> tag

URL: /en-US/docs/Web/XSLT/Using_the_Mozilla_JavaScript_interface_to_XSL_Transformations
Title: Using the Mozilla JavaScript interface to XSL Transformations
Flaw count: 14

  • macros:
    • /en-US/docs/Web/API/XSLTProcessor/importStylesheet does not exist
    • /en-US/docs/Web/API/XSLTProcessor/importStylesheet does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToDocument does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToFragment does not exist
    • /en-US/docs/Web/API/XSLTProcessor/transformToDocument does not exist
    • and 9 more flaws omitted

URL: /en-US/docs/Web/HTML/Element/table
Title: <table>: The Table element
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/SVG/Attribute/textLength
Title: textLength
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/EventListener redirects to /en-US/docs/Web/API/EventTarget/addEventListener

URL: /en-US/docs/Web/SVG/Attribute/visibility
Title: visibility
Flaw count: 4

  • macros:
    • /en-US/docs/Web/SVG/Element/audio does not exist
    • /en-US/docs/Web/SVG/Element/canvas does not exist
    • /en-US/docs/Web/SVG/Element/iframe does not exist
    • /en-US/docs/Web/SVG/Element/video does not exist

URL: /en-US/docs/Web/Media/Autoplay_guide
Title: Autoplay guide for media and Web Audio APIs
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLMediaElement/allowedToPlay does not exist

URL: /en-US/docs/Web/Progressive_web_apps/Loading
Title: Progressive loading
Flaw count: 1

  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading
External URLs (4)

URL: /en-US/docs/Web/Security/Types_of_attacks
Title: Types of attacks

URL: /en-US/docs/Web/Progressive_web_apps/Installing
Title: Installing and uninstalling web apps

(this comment was updated 2022-10-01 06:32:48.473116)

wbamberg
wbamberg reviewed Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few weird things.

files/en-us/web/progressive_web_apps/responsive/mobile_first/index.md Outdated Show resolved Hide resolved
files/en-us/web/svg/element/script/index.md Outdated Show resolved Hide resolved
files/en-us/web/web_components/using_custom_elements/index.md Outdated Show resolved Hide resolved
@OnkarRuikar
Run Prettier on JS code fences, part 7
08df46b 
The PR focuses only on JS code fences.

Idea is to gradually prettify all the JS code fences before the full automation.
@OnkarRuikar
Apply review suggestions
20f8420
@OnkarRuikar OnkarRuikar requested review from wbamberg and removed request for Elchi3 and schalkneethling October 1, 2022 04:22
wbamberg
wbamberg approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @OnkarRuikar !

@wbamberg wbamberg merged commit f7a5acc into mdn:main Oct 1, 2022
@OnkarRuikar OnkarRuikar deleted the js-code-lint8 branch October 2, 2022 01:55
@RubanChristian

This comment was marked as spam.

Sign in to view
@caugner caugner mentioned this pull request Oct 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Media Media docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OnkarRuikar @RubanChristian @wbamberg @Josh-Cena