Use EmbedLiveSample for all MathML examples #20506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Elchi3 |
Looks good to me. I'm unsure about loading the CSS with the fonts. Is that something that you guarantee to work going forward? |
|
@Elchi3 OK, this was also done in #19467 FWIW. If we don't use those web fonts, some math content may not render well in browsers, which may make some examples confusing. Alternatively, we can remove that and add a warning box, pointing to https://developer.mozilla.org/en-US/docs/Web/MathML/Fonts. |
Done: - Add live sample to show the result in the browser, replacing "rendering in your browser" for some examples. - Remove "sample rendering" for some examples, the only exception being `<mfenced>` which is not intended to be supported by browsers in the future, so it's still useful show how it was supposed to render. - Use display="block" for MathML examples, so they show up more "beautifully" (centered in their own line with optimization on readability). - Add a hidden link to math web font for some of them, to ensure that stretchy characters can display correctly. - Adjust indentation and spacing. - Other minimal tweaks of the examples (adding background to spacing elements, add click instruction to maction, split token element examples into multiple lines, fix one quote in ms example, ...) Rationale: - Makes examples a bit clearer and consistent. - All browsers are going to have MathML in the short future (or can already be enabled by a flag), using EmbedLiveSample is more convenient for maintenance of the wiki pages.
fred-wang
force-pushed
the
mathml-examples
branch
from
975dac6
to
fd10f5c
Compare
Elchi3
approved these changes
Sep 27, 2022
himanshugarg
pushed a commit
to himanshugarg/content
that referenced
this pull request
Sep 27, 2022
Done: - Add live sample to show the result in the browser, replacing "rendering in your browser" for some examples. - Remove "sample rendering" for some examples, the only exception being `<mfenced>` which is not intended to be supported by browsers in the future, so it's still useful show how it was supposed to render. - Use display="block" for MathML examples, so they show up more "beautifully" (centered in their own line with optimization on readability). - Add a hidden link to math web font for some of them, to ensure that stretchy characters can display correctly. - Adjust indentation and spacing. - Other minimal tweaks of the examples (adding background to spacing elements, add click instruction to maction, split token element examples into multiple lines, fix one quote in ms example, ...) Rationale: - Makes examples a bit clearer and consistent. - All browsers are going to have MathML in the short future (or can already be enabled by a flag), using EmbedLiveSample is more convenient for maintenance of the wiki pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<mfenced>which is not intended to be supported by browsers in the future, so it's still useful show how it was supposed to render.Motivation
Additional details
N/A
Related issues and pull requests
N/A