-
Notifications
You must be signed in to change notification settings - Fork 22.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction for the formal syntax not found issue - 03 #19473
Conversation
This sounds like it should be coming from w3c/webref… |
@teoli2003 how should I change it? |
Can you double-check the values from w3cub with the ones in mdn/data? If some are different, it would be interesting to double-check. |
How should I do that? |
I don't where w3cub is taking its syntax. It isn't a w3c official site, it's just somebody maintaining docs (which is fine). In mdn/data we were maintaining a list of formal syntax, and I would like to be sure we are completely coherent here: |
You shouldn't do it manually, we should fix the macro (or webref) to get it from w3c/webref. Only non-standard features should have hard-coded values. |
Preview URLs
FlawsNote! 1 document with no flaws that don't need to be listed. 🎉 URL:
External URLsURL: No new external URLs URL: No new external URLs (this comment was updated 2022-08-14 10:28:49.023576) |
@najmiehsa , it looks like this updated all the tags, which I already did in #19469 , as noted in #18780 (comment). If you want to help out with this issue, then I think it would be best to work on the items listed in #18780 (comment): these are nonstandard items for which we want to hardcode the formal syntax. "hardcode the formal syntax" means: find the formal syntax entry for the item in the mdn/data repository and copy it into the page, inside a Markdown For example, considering the first in this list, https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-float-edge. You can find the entry for it in mdn/data, in the "properties.json" file: https://github.com/mdn/data/blob/80aedce42a7f3a523a17e54ba87b0680ee171daf/css/properties.json#L936-L951. The formal syntax is in the "syntax" key and is given as "border-box | content-box | margin-box | padding-box". So copy that value, and in https://github.com/mdn/content/blob/main/files/en-us/web/css/-moz-float-edge/index.md, replace
I think it would be good to submit an initial PR fixing just the https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-float-edge, to be sure you have the right idea. Then you can submit another fixing the rest. Thanks for your help! |
@wbamberg I've already edited the other PR based on this. |
This is for issue #18780
In this PR I edited the tags of these pages:
I simply added CSS property tag.