Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CSS sign() function page #19471

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

wbamberg
Copy link
Collaborator

This page moves the page for the CSS sign() function from https://developer.mozilla.org/en-US/docs/Web/CSS/sign_function to https://developer.mozilla.org/en-US/docs/Web/CSS/sign .

The _function suffix breaks the bit of csssyntax that does some desperate munging of slugs to try to find a valid webref identifier, which doesn't expect this kind of form for page slugs.

Instead of moving the page we might choose to adapt csssyntax instead, or change the macro call to take an explicit argument (and as discussed in https://github.com/orgs/mdn/discussions/179 this would probably be better anyway in the long run) except that:

  • we don't use suffixes for slugs unless there is an actual name clash (for example, we don't have var_function or linear-gradient_function)
  • we don't use a _function suffix anywhere AFAIK, we only use _value

So this slug seems to be inconsistent with our practice everywhere else.

@wbamberg wbamberg requested review from a team as code owners August 12, 2022 16:37
@wbamberg wbamberg requested review from estelle and Rumyra and removed request for a team August 12, 2022 16:37
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 12, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/CSS/sign
Title: sign()
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.types.sign

External URLs

URL: /en-US/docs/Web/CSS/sign
Title: sign()
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit aa4f72f into mdn:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants