Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that URLs in the HTTP Link header must be encoded #19166

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 4, 2022

Summary

Clarify that URLs in the HTTP Link header must be encoded

Motivation

HTTP headers cannot hold characters that are frequently contained in URLs. Clarify the handling of these URLs - especially since the URLs do not need to be encoded when embedded within the page in a link element

Supporting details

nodejs/undici#1590 (comment)

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@benmccann benmccann requested a review from a team as a code owner August 4, 2022 21:10
@benmccann benmccann requested review from teoli2003 and removed request for a team August 4, 2022 21:10
@github-actions github-actions bot added the Content:HTTP HTTP docs label Aug 4, 2022
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to the glossary that explains the encoding.

files/en-us/web/http/headers/link/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Preview URLs

Flaws

URL: /en-US/docs/Web/HTTP/Headers/Link
Title: Link
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Link

External URLs

URL: /en-US/docs/Web/HTTP/Headers/Link
Title: Link
on GitHub

No new external URLs

@teoli2003 teoli2003 merged commit 1ab5f79 into mdn:main Aug 5, 2022
@teoli2003
Copy link
Contributor

Thanks a lot!

Looks good to me.

Congratulations upon your first merged commit here! Welcome aboard! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants