Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 'plain' to 'pug' identifier in code blocks #18744

Closed
wants to merge 1 commit into from

Conversation

krzysztof-tokarski
Copy link
Contributor

@krzysztof-tokarski krzysztof-tokarski commented Jul 24, 2022

I felt like these codeblock were very hard to read, especially the first one, without any kind of syntax highlighting.

Definitely looks more readable than before, yet too bad this identifier is somewhat lazy on the highlighting, dunno if its possible to achieve something closer to what I have in VSC (highlighting for html tags!)

image

EDIT:
Def would also alter the codeblock found in here:
https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Displaying_data/LocalLibrary_base_template

I felt like these codeblock were very hard to read, especially the first one, without any kind of syntax highlighting. 

Definitely looks more readable than before, yet too bad this identifier is somewhat lazy on the highlighting, dunno if its possible to achieve something closer to what I have in VSC (highlighting for html tags!)
@krzysztof-tokarski krzysztof-tokarski requested a review from a team as a code owner July 24, 2022 19:58
@krzysztof-tokarski krzysztof-tokarski requested review from teoli2003 and removed request for a team July 24, 2022 19:58
@github-actions github-actions bot added the Content:Learn Learning area docs label Jul 24, 2022
@github-actions
Copy link
Contributor

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jul 24, 2022

Thank you but pug is not supported by the MDN renderer, so this is pointless (otherwise we'd already use it. You can see it still renders as plain: https://pr18744.content.dev.mdn.mozit.cloud/en-US/docs/Learn/Server-side/Express_Nodejs/Displaying_data/Template_primer

Prism supports pug and I have asked about this in mdn/yari#6763 - I'm closing for now because this is probably not going to be a priority, and won't be done if it is "costly"

@krzysztof-tokarski
Copy link
Contributor Author

Oh you're right. I seemed to have some highlighting when previewing on GH but it's gone in that read only view. Too bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants