Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove var #18627

Merged
merged 17 commits into from
Jul 22, 2022
Merged

Remove var #18627

merged 17 commits into from
Jul 22, 2022

Conversation

Abhiram-Gullapalli
Copy link
Contributor

Summary

Motivation

Supporting details

Related issues

Resolves issue #16614

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@github-actions github-actions bot added the Content:JS JavaScript docs label Jul 22, 2022
@teoli2003
Copy link
Contributor

@Abhiram-Gullapalli This is an explanation about how var is working, so that's ok and expected to have some var there.

(We still have var to remove in Web/API)

@Abhiram-Gullapalli Abhiram-Gullapalli marked this pull request as ready for review July 22, 2022 05:43
@Abhiram-Gullapalli Abhiram-Gullapalli requested a review from a team as a code owner July 22, 2022 05:43
@Abhiram-Gullapalli Abhiram-Gullapalli requested review from Josh-Cena and removed request for a team July 22, 2022 05:43
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Classes/Class_static_initialization_blocks
Title: Class static initialization blocks
on GitHub

No new external URLs

(this comment was updated 2022-07-22 05:50:42.977686)

@Abhiram-Gullapalli
Copy link
Contributor Author

Oh I'll just close this pull then, could you give the list of files yet to be updated under the web/api section

Josh-Cena
Josh-Cena approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually an oversight and I just didn't get around to change it. After this one, JavaScript should be fully done.

@Josh-Cena Josh-Cena changed the title Var to const 3 Remove var Jul 22, 2022
@Abhiram-Gullapalli
Copy link
Contributor Author

Else you can just add them up in the doc containing all the files which are yet to be updated @teoli2003

@Josh-Cena Josh-Cena merged commit 91391d9 into mdn:main Jul 22, 2022
@teoli2003
Copy link
Contributor

Sorry, I misread. Thank you!

@Josh-Cena
Copy link
Member

Most of the var on this page is intentional—just one oversight ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhiram-Gullapalli @teoli2003 @Josh-Cena