fix: syntax errors in JS example sections (v4) #18424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
lionralfs
commented
Jul 16, 2022
lionralfs
commented
Jul 16, 2022
lionralfs
commented
Jul 16, 2022
lionralfs
commented
Jul 16, 2022
files/en-us/web/api/payment_request_api/using_the_payment_request_api/index.md
Show resolved
Hide resolved
lionralfs
commented
Jul 16, 2022
teoli2003
reviewed
Jul 16, 2022
| @@ -56,9 +56,8 @@ to the video element referenced by the variable `videoElem`. | |||
| async function capture() { | |||
| let supportedConstraints = navigator.mediaDevices.getSupportedConstraints(); | |||
There was a problem hiding this comment.
Suggested change
| let supportedConstraints = navigator.mediaDevices.getSupportedConstraints(); | |
| const supportedConstraints = navigator.mediaDevices.getSupportedConstraints(); |
files/en-us/web/api/mediatracksupportedconstraints/logicalsurface/index.md
Outdated
Show resolved
Hide resolved
Comment on lines
24
to
26
| ``` | ||
| ... | ||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ... | |
| ``` |
lionralfs
commented
Jul 16, 2022
lionralfs
commented
Jul 16, 2022
lionralfs
requested review from
sideshowbarker and
teoli2003
and removed request for
a team
teoli2003
suggested changes
Jul 16, 2022
| @@ -37,7 +37,7 @@ This proprietary method is specific to Internet Explorer. | |||
|
|
|||
| ## Example | |||
|
|
|||
| ```js | |||
| ``` | |||
There was a problem hiding this comment.
Isn't this Typescript? Same for next interface. I'm wondering should these be here as it's not really a example but just typing for this event.
There was a problem hiding this comment.
No, this is WebIDL, this is likely the only place this WebIDL is stored nowadays.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Followup to PR #18186, #18191 and #18307
Skipped issues (POTENTIALLY OUTDATED, SEE #18186 (comment)):
classas arg namereturnoutside of functionParsing error: Unexpected token :delete(key)delete()continue()delete(name)delete(name)delete(font)This PR…
-->