Replaced hasOwnProperty with hasOwn in code examples #18190

maurer2 · 2022-07-10T20:16:06Z

Summary

Hello, I replaced hasOwnProperty with hasOwn as suggested here https://github.com/orgs/mdn/discussions/143 (number 6) in various pages.
I left it in place in en-us/web/javascript/reference/global_objects/object/hasown/index.md and en-us/web/javascript/reference/global_objects/object/hasownproperty/index.md as those pages explicitly mention the differences between the two functions. Some other pages already had examples with both functions so I left them untouched was well.

Motivation

Improves legibility of code samples.

Supporting details

Discussion: https://github.com/orgs/mdn/discussions/143

This PR…

Rewrites (or significantly expands) a document

github-actions · 2022-07-11T01:33:11Z

Preview URLs

Flaws

Note! 12 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Automated_testing
Title: Introduction to automated testing
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Web/JavaScript/Guide/Working_with_Objects
Title: Working with objects
on GitHub
Flaw count: 1

macros:
- wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object
Title: Object
on GitHub
Flaw count: 2

macros:
- wrong xref macro used (consider changing which macro you use)
bad_bcd_links:
- no explanation!

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign
Title: Object.assign()
on GitHub
Flaw count: 1

macros:
- wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields
Title: Public class fields
on GitHub
Flaw count: 1

bad_bcd_links:
- no explanation!

URL: /en-US/docs/Web/API/HTMLElement/style
Title: HTMLElement.style
on GitHub
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/CSS/CSS_Properties_Reference

URL: /en-US/docs/Web/API/Media_Streams_API/Constraints
Title: Capabilities, constraints, and settings
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/API/MediaTrackCapabilities does not exist
- /en-US/docs/Web/API/MediaTrackCapabilities does not exist

External URLs

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Automated_testing
Title: Introduction to automated testing
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Guide/Indexed_collections
Title: Indexed collections
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Guide/Working_with_Objects
Title: Working with objects
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Enumerability_and_ownership_of_properties
Title: Enumerability and ownership of properties
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Errors/Undefined_prop
Title: ReferenceError: reference to undefined property "x"
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Statements/for...in
Title: for...in
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Statements/var
Title: var
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Statements/for...of
Title: for...of
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object
Title: Object
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign
Title: Object.assign()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertyNames
Title: Object.getOwnPropertyNames()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields
Title: Public class fields
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/in
Title: in operator
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer
Title: Object initializer
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/delete
Title: delete operator
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/HTMLElement/style
Title: HTMLElement.style
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Media_Streams_API/Constraints
Title: Capabilities, constraints, and settings
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Web_Workers_API/Using_web_workers
Title: Using Web Workers
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaDevices/getSupportedConstraints
Title: MediaDevices.getSupportedConstraints()
on GitHub

No new external URLs

(this comment was updated 2022-07-13 04:58:06.938455)

teoli2003 · 2022-07-11T05:50:16Z

Thanks a lot! Your PR is very valuable.

Before doing a formal review, thanks to your PR, I raised a question there. I think there is an extra pattern we should fix at the same time.

Once it is settled, we'll move forward with this PR.

zloirock · 2022-07-11T17:32:16Z

files/en-us/web/javascript/reference/statements/var/index.md

@@ -95,7 +95,7 @@ operator on a global variable.
 ```js
 'use strict';
 var x = 1;
-globalThis.hasOwnProperty('x'); // true
+Object.hasOwn(globalThis, 'x') // true


Missed ; that's present in all the rest code of the example.

Thanks. I fixed it. Although there is some weird orphaned back ticks in main in line 123, which I removed.

# Conflicts: # files/en-us/web/javascript/reference/statements/var/index.md

teoli2003

This looks good. I think there is one case where we can simplify further and get rid of hasOwnProperty/hasOwn, and simplify even more!

teoli2003 · 2022-07-12T07:33:32Z

files/en-us/learn/tools_and_testing/cross_browser_testing/automated_testing/index.md

@@ -450,7 +450,7 @@ Let's have a brief look at how we'd access the API using Node.js and [node-sauce
        myAccount.getJobs(function (err, jobs) {
          // Get a list of all your jobs
          for (let k in jobs) {


I wonder if we couldn't use for...of here and get one step further in simplifying this to:

for (const job of jobs) { myAccount.showJob(job.id, function (err, res) { let str = res.id + ": Status: " + res.status; if (res.error) { str += "\033[31m Error: " + res.error + " \033[0m"; } console.log(str); } }

Okay, make sense. Thanks. I implemented the change.

teoli2003

👍

Replaced hasOwnProperty with hasOwn

b46b618

github-actions bot added Content:JS JavaScript docs Content:Learn Learning area docs Content:WebAPI Web API docs labels Jul 10, 2022

maurer2 added 2 commits July 10, 2022 21:17

Fixed lock files

aa9a6c8

Cleanup

bd8bfb3

maurer2 marked this pull request as ready for review July 10, 2022 20:30

maurer2 requested review from a team as code owners July 10, 2022 20:30

maurer2 requested review from sideshowbarker and removed request for a team July 10, 2022 20:30

maurer2 changed the title ~~Replaced hasOwnProperty with hasOwn~~ Replaced hasOwnProperty with hasOwn in code examples Jul 10, 2022

teoli2003 requested review from teoli2003 and removed request for a team and sideshowbarker July 11, 2022 06:11

zloirock reviewed Jul 11, 2022

View reviewed changes

maurer2 and others added 4 commits July 11, 2022 21:58

Restored semicolon in code example on var page

cb92b6f

Merge branch 'main' of github.com:maurer2/mdn into modernization-has-own

f7d32bc

# Conflicts: # files/en-us/web/javascript/reference/statements/var/index.md

Fixed conflict

ed80234

Merge branch 'main' into modernization-has-own

5895570

teoli2003 suggested changes Jul 12, 2022

View reviewed changes

maurer2 and others added 2 commits July 12, 2022 20:48

Merge branch 'main' into modernization-has-own

2dbbc70

Implemented proposed code change

527a6dc

teoli2003 approved these changes Jul 13, 2022

View reviewed changes

teoli2003 merged commit eb93656 into mdn:main Jul 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replaced hasOwnProperty with hasOwn in code examples #18190

Replaced hasOwnProperty with hasOwn in code examples #18190

maurer2 commented Jul 10, 2022 •

edited

Loading

github-actions bot commented Jul 11, 2022 •

edited

Loading

teoli2003 commented Jul 11, 2022

zloirock Jul 11, 2022

maurer2 Jul 11, 2022

teoli2003 left a comment

teoli2003 Jul 12, 2022

maurer2 Jul 12, 2022

teoli2003 left a comment

Replaced hasOwnProperty with hasOwn in code examples #18190

Replaced hasOwnProperty with hasOwn in code examples #18190

Conversation

maurer2 commented Jul 10, 2022 • edited Loading

Summary

Motivation

Supporting details

github-actions bot commented Jul 11, 2022 • edited Loading

Preview URLs

Flaws

External URLs

teoli2003 commented Jul 11, 2022

zloirock Jul 11, 2022

Choose a reason for hiding this comment

maurer2 Jul 11, 2022

Choose a reason for hiding this comment

teoli2003 left a comment

Choose a reason for hiding this comment

teoli2003 Jul 12, 2022

Choose a reason for hiding this comment

maurer2 Jul 12, 2022

Choose a reason for hiding this comment

teoli2003 left a comment

Choose a reason for hiding this comment

maurer2 commented Jul 10, 2022 •

edited

Loading

github-actions bot commented Jul 11, 2022 •

edited

Loading