Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code style of Proxy handler example #17780

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Improve code style of Proxy handler example #17780

merged 5 commits into from
Jul 1, 2022

Conversation

sentyaev
Copy link
Contributor

@sentyaev sentyaev commented Jun 29, 2022 •
edited
Loading

Summary

Fixes missing colon and function keyword in A complete traps list example code sample on Proxy page.

Motivation

Fix typo.

Supporting details

--

Related issues

--

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@sentyaev
fix: missing semicolon and function keyword
fb45017 
Fixes code sample in "A complete `traps` list example" code sample.
@sentyaev sentyaev requested a review from a team as a code owner June 29, 2022 18:09
@sentyaev sentyaev requested review from Josh-Cena and removed request for a team June 29, 2022 18:09
@github-actions github-actions bot added the Content:JS JavaScript docs label Jun 29, 2022
@sentyaev sentyaev changed the title fix: missing semicolon and function keyword fix: missing colon and function keyword Jun 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy
Title: Proxy
on GitHub

No new external URLs

(this comment was updated 2022-06-30 11:18:29.353894)

Josh-Cena
Josh-Cena requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi—this code is correct, and we prefer the method syntax these days. Could you refactor the other code to this syntax instead?

@sentyaev
Copy link
Contributor Author

Hi—this code is correct, and we prefer the method syntax these days. Could you refactor the other code to this syntax instead?

Sure! np
@Josh-Cena I'm thinking to also make variable names in this code block more consistent with the rest of this file code samples. This code block has Hungarian notation for variable name, so I'm going to change it to be JS'y names.

@teoli2003
Copy link
Contributor

Yes, please, feel free to remove variables named using Hungarian notation.

@Josh-Cena Josh-Cena changed the title fix: missing colon and function keyword Improve code style of Proxy handler example Jun 30, 2022
@sentyaev sentyaev requested a review from Josh-Cena June 30, 2022 19:57
@sentyaev
Copy link
Contributor Author

@Josh-Cena I think it's done. Ping me in case you thing more changes needed.

Josh-Cena
Josh-Cena approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the change looks good to me.

Congratulations on your first contribution here—welcome aboard!

@Josh-Cena Josh-Cena merged commit 8a60914 into mdn:main Jul 1, 2022
@sentyaev sentyaev deleted the patch-1 branch July 1, 2022 05:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sentyaev @teoli2003 @Josh-Cena