-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split dynamic import into its own page #17402
Conversation
Preview URLs
FlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2022-06-18 07:59:54.835618) |
e1288b8
to
0cbbfff
Compare
- Reference | ||
- dynamic import | ||
- import | ||
browser-compat: javascript.operators.import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this also needs work from BCD to split the compat table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need a new file there: https://github.com/mdn/browser-compat-data/tree/main/javascript/operators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is a good idea. I've added a few comments and suggestions.
files/en-us/web/javascript/reference/statements/import/index.md
Outdated
Show resolved
Hide resolved
a5563b1
to
0237591
Compare
Looks good to me. Let's wait until the PR for bcd is created before formally reviewing and merging this. |
I also noticed |
BCD PR has now been merged! |
Thank you |
Summary
Motivation
Fix #10550
Dynamic import and static imports are very different: the former is an expression, the latter is a declaration. Dynamic imports are allowed in non-modules. Dynamic imports allow arbitrary expressions as specifiers. All these differences make it reasonable to split them into two pages.
Supporting details
Related issues
Metadata