Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vars from Uint16array constructor page #16973

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Remove vars from Uint16array constructor page #16973

merged 1 commit into from
Jun 4, 2022

Conversation

cw118
Copy link
Member

@cw118 cw118 commented Jun 4, 2022

Summary

Replaces var by const and changes a variable name to avoid errors.

Motivation

Updates per ES6. I noticed these when reviewing at translated-content and I thought I would create a PR here to remove var.

Related issues

This seems related to #16614

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@cw118 cw118 requested a review from a team as a code owner June 4, 2022 13:43
@cw118 cw118 requested review from sideshowbarker and removed request for a team June 4, 2022 13:43
@github-actions github-actions bot added the Content:JS JavaScript docs label Jun 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint16Array/Uint16Array
Title: Uint16Array() constructor
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes Jun 4, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @cw118 !

@wbamberg wbamberg merged commit 69c8a87 into mdn:main Jun 4, 2022
@cw118 cw118 deleted the patch-1 branch June 4, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cw118 @wbamberg