Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the variable tags #16693

Merged
merged 2 commits into from
May 26, 2022
Merged

Updating the variable tags #16693

merged 2 commits into from
May 26, 2022

Conversation

Abhiram-Gullapalli
Copy link
Contributor

@Abhiram-Gullapalli Abhiram-Gullapalli commented May 26, 2022 •
edited
Loading

Summary

Motivation

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Abhiram-Gullapalli Abhiram-Gullapalli requested a review from a team as a code owner May 26, 2022 18:28
@Abhiram-Gullapalli Abhiram-Gullapalli requested review from jpmedley and removed request for a team May 26, 2022 18:28
@github-actions github-actions bot added the Content:WebAPI Web API docs label May 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/AudioBuffer/duration
Title: AudioBuffer.duration
on GitHub

No new external URLs

(this comment was updated 2022-05-26 18:48:53.416820)

wbamberg
wbamberg requested changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I think a couple of those let declarations could be const.

files/en-us/web/api/audiobuffer/duration/index.md Outdated Show resolved Hide resolved
@wbamberg
Copy link
Collaborator

Also, please follow the instructions in #16662 (comment), or it gets really hard to keep track of the changes.

@Abhiram-Gullapalli
Copy link
Contributor Author

I knew this would happen.
It's just for this particular file, I'll group them for the next pr.
Thank you for the suggestion with the variables, I knew those two were meant to be const somehow ended up declaring them let.

wbamberg
wbamberg approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great, thank you @gullapalli9482 !

@wbamberg wbamberg merged commit 44602c1 into mdn:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhiram-Gullapalli @wbamberg