Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prototype from title #15525

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Remove prototype from title #15525

merged 1 commit into from
Apr 29, 2022

Conversation

teoli2003
Copy link
Contributor

In web/api we don't put the word prototype like in web/javascript. This PR fixes one occurrence of it.

@teoli2003 teoli2003 requested a review from a team as a code owner April 29, 2022 14:04
@teoli2003 teoli2003 requested review from wbamberg and removed request for a team April 29, 2022 14:04
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 29, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/Worker/postMessage
Title: Worker.postMessage()
on GitHub

No new external URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 someday we should do https://github.com/mdn/content/discussions/5121#discussioncomment-785747 (I wonder if @OnkarRuikar wants to take it on :) although it is a big project).

@wbamberg wbamberg merged commit 4a4a45f into main Apr 29, 2022
@wbamberg wbamberg deleted the teoli2003-prototype branch April 29, 2022 15:22
@OnkarRuikar
Copy link
Contributor

👍 someday we should do #5121 (comment) (I wonder if @OnkarRuikar wants to take it on :) although it is a big project).

Would love to.
Looks like param sections in method pages are going to take equal amount of time as syntax sections did.

@wbamberg
Copy link
Collaborator

No rush, we've been trying to fix page titles for about 5 years :).

@hamishwillee
Copy link
Collaborator

👍 someday we should do https://github.com/mdn/content/discussions/5121#discussioncomment-785747 (I wonder if @OnkarRuikar wants to take it on :) although it is a big project).

@wbamberg @OnkarRuikar I don't want to derail the conversation, but please tell me that we will roll this out consistently across both JavaScript and Web APIs?

@wbamberg
Copy link
Collaborator

wbamberg commented May 2, 2022

I think as things stand https://github.com/mdn/content/discussions/5121#discussioncomment-785747 is only about Web APIs, in part because the objection people have raised about the way we title Web API pages doesn't apply to the JS pages, because Thing.prototype.method() is valid JS.

But I agree with you, we should make it apply to both. I added it to the MDN editorial meeting agenda for tomorrow.

On a similar note actually, I was thinking about some of the work to clarify page structures for Web APIs (like #15145 and #15474) and thought, we should have a single template for Web APIs and JS pages.

@hamishwillee
Copy link
Collaborator

On a similar note actually, I was thinking about some of the work to clarify page structures for Web APIs (like #15145 and #15474) and thought, we should have a single template for Web APIs and JS pages.

Yes. IMO the most important thing is consistency across these domains. While I much prefer the idea of using static as we are proposing (everywhere), I would prefer using prototype everywhere than having the inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants