-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prototype from title #15525
Remove prototype from title #15525
Conversation
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 someday we should do https://github.com/mdn/content/discussions/5121#discussioncomment-785747 (I wonder if @OnkarRuikar wants to take it on :) although it is a big project).
Would love to. |
No rush, we've been trying to fix page titles for about 5 years :). |
@wbamberg @OnkarRuikar I don't want to derail the conversation, but please tell me that we will roll this out consistently across both JavaScript and Web APIs? |
I think as things stand https://github.com/mdn/content/discussions/5121#discussioncomment-785747 is only about Web APIs, in part because the objection people have raised about the way we title Web API pages doesn't apply to the JS pages, because Thing.prototype.method() is valid JS. But I agree with you, we should make it apply to both. I added it to the MDN editorial meeting agenda for tomorrow. On a similar note actually, I was thinking about some of the work to clarify page structures for Web APIs (like #15145 and #15474) and thought, we should have a single template for Web APIs and JS pages. |
Yes. IMO the most important thing is consistency across these domains. While I much prefer the idea of using static as we are proposing (everywhere), I would prefer using prototype everywhere than having the inconsistency. |
In web/api we don't put the word
prototype
like in web/javascript. This PR fixes one occurrence of it.