Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #1357

Closed
wants to merge 1 commit into from
Closed

Update index.html #1357

wants to merge 1 commit into from

Conversation

timohaver
Copy link
Contributor

favourite -> favorite
colour -> color

favourite -> favorite
colour -> color
@timohaver timohaver requested a review from a team as a code owner January 15, 2021 15:26
@timohaver timohaver requested review from zombie and removed request for a team January 15, 2021 15:26
Copy link
Member

@zombie zombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any discussion for doing this change?

favourite colour is sort of a theme in webext examples, see https://github.com/mdn/webextensions-examples/tree/master/favourite-colour, which is linked from some mdn pages, and all of that would need to change for consistency, while being careful not to break links.

Unless there are good reasons, I don't think these kinds of changes are worth the hassle.

@hamishwillee
Copy link
Collaborator

Well, the default language of the docs is US-English, and the changes are being done generally to match that across the wiki. So FWIW I think that if someone is willing to do these changes and make them carefully everywhere this is a good thing.

@Ryuno-Ki
Copy link
Collaborator

@zombie See #373

sideshowbarker
sideshowbarker previously approved these changes Feb 24, 2021
@sideshowbarker sideshowbarker dismissed their stale review February 24, 2021 04:00

this needs other reviewer resolution

@sideshowbarker
Copy link
Collaborator

Closing this unmerged per #1357 (review)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants