chore: make Markdownlint a dependency and script #12316
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "problemMatcher": [ | ||
| { | ||
| "owner": "markdownlint", | ||
nschonni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "pattern": [ | ||
| { | ||
| "regexp": "^([^:]*):(\\d+):?(\\d+)?\\s([\\w-\\/]*)\\s(.*)$", | ||
| "file": 1, | ||
| "line": 2, | ||
| "column": 3, | ||
| "code": 4, | ||
| "message": 5 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,5 +101,7 @@ | |
| "style": "fenced" | ||
| }, | ||
| "MD049": false, | ||
| "MD050": false, | ||
| "MD051": false, | ||
| "MD052": false | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,11 +11,14 @@ | |
| "start": "yarn up-to-date-check && env-cmd --silent cross-env CONTENT_ROOT=files REACT_APP_DISABLE_AUTH=true BUILD_OUT_ROOT=build yari-server", | ||
| "filecheck": "env-cmd --silent cross-env CONTENT_ROOT=files yari-filecheck --cwd=.", | ||
| "content": "env-cmd --silent cross-env CONTENT_ROOT=files yari-tool", | ||
| "build": "env-cmd --silent cross-env CONTENT_ROOT=files BUILD_OUT_ROOT=build yari-build", | ||
| "fix:md": "npm run lint:md -- --fix", | ||
| "lint:md": "markdownlint \"**/*.md\" -i node_modules" | ||
|
There was a problem hiding this comment. Would it be helpfull to have a "fix" target like There was a problem hiding this comment. Hmmm. I would definitely like to auto fix any cases of too many empty lines at the end. But without a better view of the full set of things it might fix, not sure I'd like to do this as a blanket thing. I guess perhaps the answer should be "yes" and then we tune it until that is something we're happy to just do. Otherwise this can never be a CI mandated thing. There was a problem hiding this comment. OK, I can add the extra target. Does it make sense to keep the scoped There was a problem hiding this comment. I don't think it matters all that much, but personally I'd keep md because there are some html docs still in-tree. There was a problem hiding this comment. Is there any reason not to use There was a problem hiding this comment. We know about the There was a problem hiding this comment. Hm, I understand. Maybe still call it There was a problem hiding this comment. @caugner There is going to be one for JavaScript. There was a problem hiding this comment. Okay, makes sense then. Maybe linting JavaScript and Markdown could be integrated via ESLint (eslint-plugin-markdownlint + eslint-plugin-prettier) in the future. |
||
| }, | ||
| "dependencies": { | ||
| "@mdn/yari": "1.14.39", | ||
| "cross-env": "7.0.3", | ||
| "env-cmd": "10.1.0", | ||
| "markdownlint-cli": "0.32.2" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -564,6 +564,13 @@ brace-expansion@^1.1.7: | |
| balanced-match "^1.0.0" | ||
| concat-map "0.0.1" | ||
|
|
||
| brace-expansion@^2.0.1: | ||
| version "2.0.1" | ||
| resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-2.0.1.tgz#1edc459e0f0c548486ecf9fc99f2221364b9a0ae" | ||
| integrity sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA== | ||
| dependencies: | ||
| balanced-match "^1.0.0" | ||
|
|
||
| braces@^3.0.1: | ||
| version "3.0.2" | ||
| resolved "https://registry.yarnpkg.com/braces/-/braces-3.0.2.tgz#3454e1a462ee8d599e236df336cd9ea4f8afe107" | ||
|
|
@@ -914,6 +921,11 @@ commander@^7.1.0: | |
| resolved "https://registry.yarnpkg.com/commander/-/commander-7.1.0.tgz#f2eaecf131f10e36e07d894698226e36ae0eb5ff" | ||
| integrity sha512-pRxBna3MJe6HKnBGsDyMv8ETbptw3axEdYHoqNh7gu5oDcew8fs0xnivZGm06Ogk8zGAJ9VX+OPEr2GXEQK4dg== | ||
|
|
||
| commander@~9.4.0: | ||
| version "9.4.0" | ||
| resolved "https://registry.yarnpkg.com/commander/-/commander-9.4.0.tgz#bc4a40918fefe52e22450c111ecd6b7acce6f11c" | ||
| integrity sha512-sRPT+umqkz90UA8M1yqYfnHlZA7fF6nSphDtxeywPZ49ysjxDQybzk13CL+mXekDRG92skbcqCLVovuCusNmFw== | ||
|
|
||
| compressible@~2.0.16: | ||
| version "2.0.18" | ||
| resolved "https://registry.yarnpkg.com/compressible/-/compressible-2.0.18.tgz#af53cca6b070d4c3c0750fbd77286a6d7cc46fba" | ||
|
|
@@ -1210,6 +1222,11 @@ decompress@^4.0.0, decompress@^4.2.0: | |
| pify "^2.3.0" | ||
| strip-dirs "^2.0.0" | ||
|
|
||
| deep-extend@^0.6.0: | ||
| version "0.6.0" | ||
| resolved "https://registry.yarnpkg.com/deep-extend/-/deep-extend-0.6.0.tgz#c4fa7c95404a17a9c3e8ca7e1537312b736330ac" | ||
| integrity sha512-LOHxIOaPYdHlJRtCQfDIVZtfw/ufM8+rVj649RIHzcm/vGwQRXFt6OPqIFWsm2XEMrNIEtWR64sY1LEKD2vAOA== | ||
|
|
||
| defaults@^1.0.3: | ||
| version "1.0.3" | ||
| resolved "https://registry.yarnpkg.com/defaults/-/defaults-1.0.3.tgz#c656051e9817d9ff08ed881477f3fe4019f3ef7d" | ||
|
|
@@ -1433,6 +1450,11 @@ entities@^4.2.0, entities@^4.3.0: | |
| resolved "https://registry.yarnpkg.com/entities/-/entities-4.3.0.tgz#62915f08d67353bb4eb67e3d62641a4059aec656" | ||
| integrity sha512-/iP1rZrSEJ0DTlPiX+jbzlA3eVkY/e8L8SozroF395fIqE3TYF/Nz7YOMAawta+vLmyJ/hkGNNPcSbMADCCXbg== | ||
|
|
||
| entities@~3.0.1: | ||
| version "3.0.1" | ||
| resolved "https://registry.yarnpkg.com/entities/-/entities-3.0.1.tgz#2b887ca62585e96db3903482d336c1006c3001d4" | ||
| integrity sha512-WiyBqoomrwMdFG1e0kqvASYfnlb0lp8M5o5Fw2OFq1hNZxxcNk8Ik0Xm7LxzBhuidnZB/UtBqVCgUz3kBOP51Q== | ||
|
|
||
| [email protected]: | ||
| version "10.1.0" | ||
| resolved "https://registry.yarnpkg.com/env-cmd/-/env-cmd-10.1.0.tgz#c7f5d3b550c9519f137fdac4dd8fb6866a8c8c4b" | ||
|
|
@@ -1882,6 +1904,11 @@ get-stdin@^4.0.1: | |
| resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-4.0.1.tgz#b968c6b0a04384324902e8bf1a5df32579a450fe" | ||
| integrity sha1-uWjGsKBDhDJJAui/Gl3zJXmkUP4= | ||
|
|
||
| get-stdin@~9.0.0: | ||
| version "9.0.0" | ||
| resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-9.0.0.tgz#3983ff82e03d56f1b2ea0d3e60325f39d703a575" | ||
| integrity sha512-dVKBjfWisLAicarI2Sf+JuBE/DghV4UzNAVe9yhEJuzeREd3JhOTE9cUaJTeSa77fsbQUK3pcOpJfM59+VKZaA== | ||
|
|
||
| [email protected], get-stream@^3.0.0: | ||
| version "3.0.0" | ||
| resolved "https://registry.yarnpkg.com/get-stream/-/get-stream-3.0.0.tgz#8e943d1358dc37555054ecbe2edb05aa174ede14" | ||
|
|
@@ -1943,6 +1970,17 @@ glob@^7.1.3, glob@^7.1.6: | |
| once "^1.3.0" | ||
| path-is-absolute "^1.0.0" | ||
|
|
||
| glob@~8.0.3: | ||
| version "8.0.3" | ||
| resolved "https://registry.yarnpkg.com/glob/-/glob-8.0.3.tgz#415c6eb2deed9e502c68fa44a272e6da6eeca42e" | ||
| integrity sha512-ull455NHSHI/Y1FqGaaYFaLGkNMMJbavMrEGFXG/PGrg6y7sutWHUHrz6gy6WEBH6akM1M414dWKCNs+IhKdiQ== | ||
| dependencies: | ||
| fs.realpath "^1.0.0" | ||
| inflight "^1.0.4" | ||
| inherits "2" | ||
| minimatch "^5.0.1" | ||
| once "^1.3.0" | ||
|
|
||
| globby@^10.0.0: | ||
| version "10.0.2" | ||
| resolved "https://registry.yarnpkg.com/globby/-/globby-10.0.2.tgz#277593e745acaa4646c3ab411289ec47a0392543" | ||
|
|
@@ -2356,6 +2394,11 @@ ignore@^5.1.1, ignore@^5.1.4: | |
| resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.1.8.tgz#f150a8b50a34289b33e22f5889abd4d8016f0e57" | ||
| integrity sha512-BMpfD7PpiETpBl/A6S498BaIJ6Y/ABT93ETbby2fP00v4EbvPBXWEoaR1UBPKs3iR53pJY7EtZk5KACI57i1Uw== | ||
|
|
||
| ignore@~5.2.0: | ||
| version "5.2.0" | ||
| resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.2.0.tgz#6d3bac8fa7fe0d45d9f9be7bac2fc279577e345a" | ||
| integrity sha512-CmxgYGiEPCLhfLnpPp1MoRmifwEIOgjcHXxOBjv7mY96c+eWScsOP9c112ZyLdWHi0FxHjI+4uVhKYp/gcdRmQ== | ||
|
|
||
| image-size@^1.0.2: | ||
| version "1.0.2" | ||
| resolved "https://registry.yarnpkg.com/image-size/-/image-size-1.0.2.tgz#d778b6d0ab75b2737c1556dd631652eb963bc486" | ||
|
|
@@ -2455,6 +2498,11 @@ ini@^1.3.4: | |
| resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927" | ||
| integrity sha512-RZY5huIKCMRWDUqZlEi72f/lmXKMvuszcMBduliQ3nnWbx9X/ZBQO7DijMEYS9EhHBb2qacRUMtC7svLwe0lcw== | ||
|
|
||
| ini@~3.0.0: | ||
| version "3.0.0" | ||
| resolved "https://registry.yarnpkg.com/ini/-/ini-3.0.0.tgz#2f6de95006923aa75feed8894f5686165adc08f1" | ||
| integrity sha512-TxYQaeNW/N8ymDvwAxPyRbhMBtnEwuvaTYpOQkFx1nSeusgezHniEc/l35Vo4iCq/mMiTJbpD7oYxN98hFlfmw== | ||
|
|
||
| [email protected]: | ||
| version "0.1.1" | ||
| resolved "https://registry.yarnpkg.com/inline-style-parser/-/inline-style-parser-0.1.1.tgz#ec8a3b429274e9c0a1f1c4ffa9453a7fef72cea1" | ||
|
|
@@ -2747,6 +2795,11 @@ json-schema-traverse@^0.4.1: | |
| resolved "https://registry.yarnpkg.com/json-schema-traverse/-/json-schema-traverse-0.4.1.tgz#69f6a87d9513ab8bb8fe63bdb0979c448e684660" | ||
| integrity sha512-xbbCH5dCYU5T8LcEhhuh7HJ88HXuW3qsI3Y0zOZFKfZEHcpWiHU/Jxzk629Brsab/mMiHQti9wMP+845RPe3Vg== | ||
|
|
||
| jsonc-parser@~3.1.0: | ||
| version "3.1.0" | ||
| resolved "https://registry.yarnpkg.com/jsonc-parser/-/jsonc-parser-3.1.0.tgz#73b8f0e5c940b83d03476bc2e51a20ef0932615d" | ||
| integrity sha512-DRf0QjnNeCUds3xTjKlQQ3DpJD51GvDjJfnxUVWg6PZTo2otSm+slzNAxU/35hF8/oJIKoG9slq30JYOsF2azg== | ||
|
|
||
| jsonfile@^6.0.1: | ||
| version "6.0.1" | ||
| resolved "https://registry.yarnpkg.com/jsonfile/-/jsonfile-6.0.1.tgz#98966cba214378c8c84b82e085907b40bf614179" | ||
|
|
@@ -2796,6 +2849,13 @@ line-column-path@^2.0.0: | |
| dependencies: | ||
| type-fest "^0.4.1" | ||
|
|
||
| linkify-it@^4.0.1: | ||
| version "4.0.1" | ||
| resolved "https://registry.yarnpkg.com/linkify-it/-/linkify-it-4.0.1.tgz#01f1d5e508190d06669982ba31a7d9f56a5751ec" | ||
| integrity sha512-C7bfi1UZmoj8+PQx22XyeXCuBlokoyWQL5pWSP+EI6nzRylyThouddufc2c1NDIcP9k5agmN9fLpA7VNJfIiqw== | ||
| dependencies: | ||
| uc.micro "^1.0.1" | ||
|
|
||
| load-json-file@^1.0.0: | ||
| version "1.1.0" | ||
| resolved "https://registry.yarnpkg.com/load-json-file/-/load-json-file-1.1.0.tgz#956905708d58b4bab4c2261b04f59f31c99374c0" | ||
|
|
@@ -2971,13 +3031,52 @@ map-obj@^1.0.0, map-obj@^1.0.1: | |
| resolved "https://registry.yarnpkg.com/map-obj/-/map-obj-1.0.1.tgz#d933ceb9205d82bdcf4886f6742bdc2b4dea146d" | ||
| integrity sha1-2TPOuSBdgr3PSIb2dCvcK03qFG0= | ||
|
|
||
| [email protected]: | ||
| version "13.0.1" | ||
| resolved "https://registry.yarnpkg.com/markdown-it/-/markdown-it-13.0.1.tgz#c6ecc431cacf1a5da531423fc6a42807814af430" | ||
| integrity sha512-lTlxriVoy2criHP0JKRhO2VDG9c2ypWCsT237eDiLqi09rmbKoUetyGHq2uOIRoRS//kfoJckS0eUzzkDR+k2Q== | ||
| dependencies: | ||
| argparse "^2.0.1" | ||
| entities "~3.0.1" | ||
| linkify-it "^4.0.1" | ||
| mdurl "^1.0.1" | ||
| uc.micro "^1.0.5" | ||
|
|
||
| markdown-table@^2.0.0: | ||
| version "2.0.0" | ||
| resolved "https://registry.yarnpkg.com/markdown-table/-/markdown-table-2.0.0.tgz#194a90ced26d31fe753d8b9434430214c011865b" | ||
| integrity sha512-Ezda85ToJUBhM6WGaG6veasyym+Tbs3cMAw/ZhOPqXiYsr0jgocBV3j3nx+4lk47plLlIqjwuTm/ywVI+zjJ/A== | ||
| dependencies: | ||
| repeat-string "^1.0.0" | ||
|
|
||
| [email protected]: | ||
| version "0.32.2" | ||
| resolved "https://registry.yarnpkg.com/markdownlint-cli/-/markdownlint-cli-0.32.2.tgz#b7b5c5808039aef4022aef603efaa607caf8e0de" | ||
| integrity sha512-xmJT1rGueUgT4yGNwk6D0oqQr90UJ7nMyakXtqjgswAkEhYYqjHew9RY8wDbOmh2R270IWjuKSeZzHDEGPAUkQ== | ||
| dependencies: | ||
| commander "~9.4.0" | ||
| get-stdin "~9.0.0" | ||
| glob "~8.0.3" | ||
| ignore "~5.2.0" | ||
| js-yaml "^4.1.0" | ||
| jsonc-parser "~3.1.0" | ||
| markdownlint "~0.26.2" | ||
| markdownlint-rule-helpers "~0.17.2" | ||
| minimatch "~5.1.0" | ||
| run-con "~1.2.11" | ||
|
|
||
| markdownlint-rule-helpers@~0.17.2: | ||
| version "0.17.2" | ||
| resolved "https://registry.yarnpkg.com/markdownlint-rule-helpers/-/markdownlint-rule-helpers-0.17.2.tgz#64d6e8c66e497e631b0e40cf1cef7ca622a0b654" | ||
| integrity sha512-XaeoW2NYSlWxMCZM2B3H7YTG6nlaLfkEZWMBhr4hSPlq9MuY2sy83+Xr89jXOqZMZYjvi5nBCGoFh7hHoPKZmA== | ||
|
|
||
| markdownlint@~0.26.2: | ||
| version "0.26.2" | ||
| resolved "https://registry.yarnpkg.com/markdownlint/-/markdownlint-0.26.2.tgz#11d3d03e7f0dd3c2e239753ee8fd064a861d9237" | ||
| integrity sha512-2Am42YX2Ex5SQhRq35HxYWDfz1NLEOZWWN25nqd2h3AHRKsGRE+Qg1gt1++exW792eXTrR4jCNHfShfWk9Nz8w== | ||
| dependencies: | ||
| markdown-it "13.0.1" | ||
|
|
||
| md5-file@^5.0.0: | ||
| version "5.0.0" | ||
| resolved "https://registry.yarnpkg.com/md5-file/-/md5-file-5.0.0.tgz#e519f631feca9c39e7f9ea1780b63c4745012e20" | ||
|
|
@@ -3105,7 +3204,7 @@ [email protected], mdn-data@^2.0.28: | |
| resolved "https://registry.yarnpkg.com/mdn-data/-/mdn-data-2.0.28.tgz#5ec48e7bef120654539069e1ae4ddc81ca490eba" | ||
| integrity sha512-aylIc7Z9y4yzHYAJNuESG3hfhC+0Ibp/MAMiaOZgNv4pmEdFyfZhhhny4MNiAfWdBQ1RQ2mfDWmM1x8SvGyp8g== | ||
|
|
||
| mdurl@^1.0.0, mdurl@^1.0.1: | ||
| version "1.0.1" | ||
| resolved "https://registry.yarnpkg.com/mdurl/-/mdurl-1.0.1.tgz#fe85b2ec75a59037f2adfec100fd6c601761152e" | ||
| integrity sha1-/oWy7HWlkDfyrf7BAP1sYBdhFS4= | ||
|
|
@@ -3273,11 +3372,23 @@ minimatch@^3.0.4: | |
| dependencies: | ||
| brace-expansion "^1.1.7" | ||
|
|
||
| minimatch@^5.0.1, minimatch@~5.1.0: | ||
| version "5.1.0" | ||
| resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-5.1.0.tgz#1717b464f4971b144f6aabe8f2d0b8e4511e09c7" | ||
| integrity sha512-9TPBGGak4nHfGZsPBohm9AWg6NoT7QTCehS3BIJABslyZbzxfV78QM2Y6+i741OPZIafFAaiiEMh5OyIrJPgtg== | ||
| dependencies: | ||
| brace-expansion "^2.0.1" | ||
|
|
||
| minimist@^1.1.3, minimist@^1.2.0, minimist@^1.2.5: | ||
| version "1.2.5" | ||
| resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.5.tgz#67d66014b66a6a8aaa0c083c5fd58df4e4e97602" | ||
| integrity sha512-FM9nNUYrRBAELZQT3xeZQ7fmMOBg6nWNmJKTcgsJeaLstP/UODVpGsr5OhXhhXg6f+qtJ8uiZ+PUxkDWcgIXLw== | ||
|
|
||
| minimist@^1.2.6: | ||
| version "1.2.6" | ||
| resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44" | ||
| integrity sha512-Jsjnk4bw3YJqYzbdyBiNsPWHPfO++UGG749Cxs6peCu5Xg4nrena6OVxOYxrQTqww0Jmwt+Ref8rggumkTLz9Q== | ||
|
|
||
| mkdirp@^0.5.1: | ||
| version "0.5.5" | ||
| resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.5.tgz#d91cefd62d1436ca0f41620e251288d420099def" | ||
|
|
@@ -4083,6 +4194,16 @@ run-async@^2.2.0, run-async@^2.4.0: | |
| resolved "https://registry.yarnpkg.com/run-async/-/run-async-2.4.1.tgz#8440eccf99ea3e70bd409d49aab88e10c189a455" | ||
| integrity sha512-tvVnVv01b8c1RrA6Ep7JkStj85Guv/YrMcwqYQnwjsAS2cTmmPGBBjAjpCW7RrSodNSoE2/qg9O4bceNvUuDgQ== | ||
|
|
||
| run-con@~1.2.11: | ||
| version "1.2.11" | ||
| resolved "https://registry.yarnpkg.com/run-con/-/run-con-1.2.11.tgz#0014ed430bad034a60568dfe7de2235f32e3f3c4" | ||
| integrity sha512-NEMGsUT+cglWkzEr4IFK21P4Jca45HqiAbIIZIBdX5+UZTB24Mb/21iNGgz9xZa8tL6vbW7CXmq7MFN42+VjNQ== | ||
| dependencies: | ||
| deep-extend "^0.6.0" | ||
| ini "~3.0.0" | ||
| minimist "^1.2.6" | ||
| strip-json-comments "~3.1.1" | ||
|
|
||
| run-parallel@^1.1.9: | ||
| version "1.1.9" | ||
| resolved "https://registry.yarnpkg.com/run-parallel/-/run-parallel-1.1.9.tgz#c9dd3a7cf9f4b2c4b6244e173a6ed866e61dd679" | ||
|
|
@@ -4474,6 +4595,11 @@ strip-indent@^1.0.1: | |
| dependencies: | ||
| get-stdin "^4.0.1" | ||
|
|
||
| strip-json-comments@~3.1.1: | ||
| version "3.1.1" | ||
| resolved "https://registry.yarnpkg.com/strip-json-comments/-/strip-json-comments-3.1.1.tgz#31f1281b3832630434831c310c01cccda8cbe006" | ||
| integrity sha512-6fPc+R4ihwqP6N/aIv2f1gMH8lOVtWQHoqC4yK6oSDVVocumAsfCqjkXnqiYMhmMwS/mEHLp7Vehlt3ql6lEig== | ||
|
|
||
| strip-outer@^1.0.0: | ||
| version "1.0.1" | ||
| resolved "https://registry.yarnpkg.com/strip-outer/-/strip-outer-1.0.1.tgz#b2fd2abf6604b9d1e6013057195df836b8a9d631" | ||
|
|
@@ -4726,6 +4852,11 @@ type-is@~1.6.18: | |
| media-typer "0.3.0" | ||
| mime-types "~2.1.24" | ||
|
|
||
| uc.micro@^1.0.1, uc.micro@^1.0.5: | ||
| version "1.0.6" | ||
| resolved "https://registry.yarnpkg.com/uc.micro/-/uc.micro-1.0.6.tgz#9c411a802a409a91fc6cf74081baba34b24499ac" | ||
| integrity sha512-8Y75pvTYkLJW2hWQHXxoqRgV7qb9B+9vFEtidML+7koHUFapnVJAZ6cKs+Qjz5Aw3aZWHMC6u0wJE3At+nSGwA== | ||
|
|
||
| unbzip2-stream@^1.0.9: | ||
| version "1.4.3" | ||
| resolved "https://registry.yarnpkg.com/unbzip2-stream/-/unbzip2-stream-1.4.3.tgz#b0da04c4371311df771cdc215e87f2130991ace7" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To not exit the linter with error code
1.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, as @nschonni has pointed out, the failing check does not prevent a PR from being merged once it is approved.
This is because the following option is disabled in the protection rules for the
mainbranch: