Add guideline for removal of irrelevant data #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
docs
Elchi3
force-pushed
the
guideline-removal
branch
from
704d286 to
748f21f
Compare
ddbeck
requested changes
Apr 22, 2020
There was a problem hiding this comment.
Thank you for writing this up, Florian. I have a few ideas on how to improve this.
Two general changes I'd like to suggest:
- Can you add the section to the table of contents at the top?
- Based on our template (also near the top of the file), can we reference the PRs that prompted this? For example:
This guideline was proposed in [#6018](https://github.com/mdn/browser-compat-data/pull/6018).
I've made a few suggestions in line comments, as well.
Thank you!
Co-Authored-By: Daniel D. Beck <[email protected]>
Elchi3
force-pushed
the
guideline-removal
branch
from
5caa531 to
2979f7f
Compare
|
Thanks for your review, Daniel! |
ddbeck
approved these changes
Apr 22, 2020
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daniel is right to be explicit about when to remove data. So, here's the guideline that I just came up with.
#6017 (comment)