Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data for history.pushState/replaceState's title argument #5101

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Add data for history.pushState/replaceState's title argument #5101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions api/History.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,51 @@
"standard_track": true,
"deprecated": false
}
},
"title": {
"__compat": {
"description": "Whether the <code>title</code> argument is used",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": true
},
"safari_ios": {
"version_added": null
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
}
},
"replaceState": {
Expand Down Expand Up @@ -314,6 +359,51 @@
"standard_track": true,
"deprecated": false
}
},
"title": {
"__compat": {
"description": "Whether the <code>title</code> argument is used",
"support": {
"chrome": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome, Chrome Android, and WebView Android support this argument.

https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/history.idl

Copy link
Contributor Author

@mnoorenberghe mnoorenberghe Nov 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you read whatwg/html#2174? It explains that it's a no-op and therefore isn't "supported". I'm documenting this to avoid the issues described in whatwg/html#2174 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diving through the code reveals that the title argument, even though it's passed in, is not actually used in the underlying function call.

},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": true
},
"safari_ios": {
"version_added": null
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
}
},
"scrollRestoration": {
Expand Down