-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some font CSS properties compat data #475
Conversation
font
CSS properties compat dataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, nothing big.
css/properties/font-family.json
Outdated
"version_added": true, | ||
"notes": "Supported since iOS 9." | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add status box (standard, but experimental)
css/properties/font-family.json
Outdated
}, | ||
"safari": { | ||
"alternative_name": "-apple-system", | ||
"version_added": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version_added": "48" | ||
}, | ||
"edge": { | ||
"version_added": "40.15063.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid value for Edge (valid are "12" to "15"); it is "15".
{ | ||
"version_added": "34", | ||
"notes": [ | ||
"Starting with Firefox 34, the version prefixed with <code>-moz-</code> is only kept for backward compatibility purpose. It is controlled by the <code>layout.css.prefixes.font-features</code>, defaulting to <code>true</code>. The prefixed property will be removed in the future.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note is not useful.
}, | ||
{ | ||
"prefix": "-moz-", | ||
"version_added": "4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put "15" here. As "4" - "14" supported a different syntax.
css/properties/font.json
Outdated
"version_added": "1" | ||
}, | ||
"firefox_android": { | ||
"version_added": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"4"
css/properties/font.json
Outdated
"version_added": "3" | ||
}, | ||
"ie_mobile": { | ||
"version_added": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true
css/properties/font.json
Outdated
"version_added": "3.5" | ||
}, | ||
"opera_android": { | ||
"version_added": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true
css/properties/font.json
Outdated
"version_added": "1" | ||
}, | ||
"safari_ios": { | ||
"version_added": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true
css/properties/font.json
Outdated
} | ||
} | ||
}, | ||
"font_stretch_support": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be checked when we deal with font-stretch (no need to double check the content twice)
css/properties/font.json
Outdated
"safari_ios": { | ||
"version_added": null | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status block is missing (standard, not experimental)
css/properties/font.json
Outdated
"safari_ios": { | ||
"version_added": null | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status box is missing (standard, not experimental)
OK, I think I cleaned up everything commented. Thanks, @teoli2003! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, r+
OK, let's try out a few
font
CSS properties. This PR adds the following properties: