Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some font CSS properties compat data #475

Merged
merged 8 commits into from
Oct 10, 2017
Merged

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Oct 5, 2017

OK, let's try out a few font CSS properties. This PR adds the following properties:

@ddbeck ddbeck changed the title Add some font CSS properties compat data Add some font CSS properties compat data Oct 5, 2017
@teoli2003 teoli2003 added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 5, 2017
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, nothing big.

"version_added": true,
"notes": "Supported since iOS 9."
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add status box (standard, but experimental)

},
"safari": {
"alternative_name": "-apple-system",
"version_added": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"version_added": "48"
},
"edge": {
"version_added": "40.15063.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a valid value for Edge (valid are "12" to "15"); it is "15".

{
"version_added": "34",
"notes": [
"Starting with Firefox 34, the version prefixed with <code>-moz-</code> is only kept for backward compatibility purpose. It is controlled by the <code>layout.css.prefixes.font-features</code>, defaulting to <code>true</code>. The prefixed property will be removed in the future.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is not useful.

},
{
"prefix": "-moz-",
"version_added": "4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put "15" here. As "4" - "14" supported a different syntax.

"version_added": "1"
},
"firefox_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"4"

"version_added": "3"
},
"ie_mobile": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

"version_added": "3.5"
},
"opera_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

"version_added": "1"
},
"safari_ios": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

}
}
},
"font_stretch_support": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be checked when we deal with font-stretch (no need to double check the content twice)

"safari_ios": {
"version_added": null
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status block is missing (standard, not experimental)

"safari_ios": {
"version_added": null
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status box is missing (standard, not experimental)

@ddbeck
Copy link
Collaborator Author

ddbeck commented Oct 9, 2017

OK, I think I cleaned up everything commented. Thanks, @teoli2003!

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants