Fix consistency of css.properties.mask-* #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
added
the
data:css
jpmedley
previously requested changes
Apr 22, 2019
|
@ddbeck I read your message in that PR a little more carefully, and I see what you mean. Statements have been returned! |
jpmedley
approved these changes
Jun 27, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at all the various masking properties, it looks like there were version inconsistencies between them, which didn't seem to make sense since most of them rely on one another to obtain a complete result. (Furthermore, manual testing revealed inaccuracies in many of the versions.) This updates all the mask-* and -webkit-mask-* properties to match each other, as well as add a little manual testing data regarding Edge. (This does skip over a couple that were confirmed to be accurate.)