feat(manifest): add ./types export with separate type and default entries #27489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infra
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Contributor
Author
|
Can you review this @queengooborg? |
queengooborg
requested changes
Aug 5, 2025
Contributor
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
Thank you for your PR! This is looking good overall, there's just a couple of things to fix.
The first one is in the below review comment.
The second: may we also update the package.json in the root folder to mirror these changes?
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
github-actions
bot
added
size:s
Contributor
Author
|
Thanks for your review @queengooborg |
queengooborg
approved these changes
Aug 5, 2025
Contributor
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
Thank you, looks great! This will be included in today's release!
queengooborg
added
the
semver-minor-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
./typessubpath export to the generated manifest. It separates thetypesand default fields to better support tools and consumers that reference type definitions directly.Test results and supporting details
See Node.js package exports documentation: https://nodejs.org/api/packages.html#exports
Related issues
Fixes failing tests at microsoft/TypeScript-DOM-lib-generator#2104