Skip to content

Remove unimplemented CSS line-height-step property#26761

Merged
Elchi3 merged 2 commits intomainfrom
line-height-step-in-chrome
May 9, 2025
Merged

Remove unimplemented CSS line-height-step property#26761
Elchi3 merged 2 commits intomainfrom
line-height-step-in-chrome

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented May 9, 2025

Summary

Removes the Chrome statement for line-height-step, because it was only behind a flag, and the feature got removed.

Test results and supporting details

See:

Related issues

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed labels May 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@caugner caugner requested a review from Elchi3 May 9, 2025 13:11
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this data? Seems irrelevant to me per our data guidelines.

I was hoping to enable the linter for CSS at some point soon (just 21 data points left to remove).

See

const ignoredCategories = ['css'];

@caugner
Copy link
Contributor Author

caugner commented May 9, 2025

Ah, and I was wondering why the linter doesn't warn.

@caugner caugner changed the title Chrome 110 removed CSS line-height-step Remove unimplemented CSS line-height-step property May 9, 2025
@github-actions github-actions bot added size:m [PR only] 25-100 LoC changed and removed size:s [PR only] 7-24 LoC changed labels May 9, 2025
@caugner caugner requested a review from Elchi3 May 9, 2025 13:43
@Elchi3 Elchi3 added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label May 9, 2025
@Elchi3 Elchi3 merged commit d1b3a1c into main May 9, 2025
11 checks passed
@Elchi3 Elchi3 deleted the line-height-step-in-chrome branch May 9, 2025 13:46
@mdn-bot mdn-bot mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS needs content update This PR needs a corresponding update to mdn/content to update the documentation size:m [PR only] 25-100 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants