Sync `css.types.attr` with CSS Values 5 extensions #26624

caugner · 2025-04-25T16:14:28Z

Summary

Changes:

~~Removed type-or-unit subfeature: frequency.~~
Renamed fallback to declaration-value.
Renamed type-or-unit to type_function, adding subfeatures: <custom-ident>, <ident>, <image>, <length-percentage>, <resolution>, <string>, <transform-function>.
Wrapped all keywords in fences.
Added MDN urls, and spec urls.

Test results and supporting details

Related issues

Fixes #25618.

github-actions · 2025-04-25T16:15:21Z

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

github-actions · 2025-04-28T07:59:20Z

This pull request has merge conflicts that must be resolved before it can be merged.

css/types/attr.json

caugner · 2025-06-13T15:40:15Z

@hamishwillee Would you mind taking a look at these changes? 🙏

Changes: - Removed `type-or-unit` subfeature: `frequency`. - Renamed `fallback` to `fallback-value`. - Renamed `type-or-unit` to `type_function`. - Wrapped all keywords in fences. - Added subfeatures: `custom-ident`, `ident`, `image`, `length-percentage`, `resolution`, `string`, `transform-function`.

css/types/attr.json

hamishwillee

@caugner Sorry, I missed this request for review - I rarely get asked for reviews here, so worth pinging me directly if I can be of use.

The information seems correct, but I've added some queries on process such as https://github.com/mdn/browser-compat-data/pull/26624/files#r2214505721 that essentially ask:

Have the removed features been gone for more than two years - i.e. is it right to remove them.
Does it matter that the name of a property does not match the spec https://github.com/mdn/browser-compat-data/pull/26624/files#r2214505721 if it matches the docs
How will linking to the type_function happen? Note, I've added mdn/content#40418 to create DL links that could work. Should we manually add links.

I'm going to approve but not merge.

@chrisdavidmills You reviewed the docs. Since @caugner is heading away for a few weeks, can you answer/confirm my questions here?

css/types/attr.json

caugner · 2025-11-07T16:10:33Z

css/types/attr.json

+              ],
+              "support": {
+                "chrome": {
+                  "version_added": false


My interpretation of chromium/chromium@01b72da is that <ident> was not supported in Chrome 133.

caugner · 2025-11-07T16:10:36Z

css/types/attr.json

+              ],
+              "support": {
+                "chrome": {
+                  "version_added": false


My interpretation of chromium/chromium@01b72da is that <image> was not supported in Chrome 133.

caugner · 2025-11-07T16:10:40Z

css/types/attr.json

+              ],
+              "support": {
+                "chrome": {
+                  "version_added": false


My interpretation of chromium/chromium@01b72da is that <length-percentage> was not supported in Chrome 133.

If <length> is supported and <percentage> is supported, what does it mean for <length-percentage> to not be supported?

If I understand this correctly, then <length-percentage> is a combination (not a union) of <length> and <percentage>.

It seems to be somewhat similar to https://github.com/search?q=repo%3Amdn%2Fbrowser-compat-data+%2Fmixed_type_parameters%2F&type=code.

Let's merge as is, and follow up separately if need be.

caugner · 2025-11-07T16:10:45Z

css/types/attr.json

+              ],
+              "support": {
+                "chrome": {
+                  "version_added": false


My interpretation of chromium/chromium@01b72da is that <resolution> was not supported in Chrome 133.

css/types/attr.json

caugner · 2025-11-07T16:10:54Z

css/types/attr.json

+              ],
+              "support": {
+                "chrome": {
+                  "version_added": false


My interpretation of chromium/chromium@01b72da is that <transform-function> was not supported in Chrome 133.

css/types/attr.json

caugner · 2025-11-12T09:12:25Z

@hamishwillee Could you please take another last look? 🙏

css/types/attr.json

yisibl · 2025-11-26T04:35:36Z

css/types/attr.json

          "number": {
            "__compat": {
-              "description": "&lt;number&gt;",
+              "description": "`<number>`",


We should also add a separate number keyword.

e.g. attr(data-foo number)

See: https://chromiumdash.appspot.com/commit/def86f45b9de19ae59340f0e73cb0c50da78421e

See:

Sync css.types.attr with CSS Values 5 extensions #26624 (comment)

Sync css.types.attr with CSS Values 5 extensions #26624 (comment)

yisibl · 2025-11-26T04:44:28Z

css/types/attr.json

          }
        },
-        "type-or-unit": {
+        "type_function": {


<attr-type> = type( <syntax> ) | raw-string | number | <attr-unit>

Should we add a separate <attr-unit> type?
e.g. attr(data-foo px)

We can add that later if is there is evidence that support for different units were added at different types.

yisibl · 2025-11-26T04:49:35Z

Added subfeatures: custom-ident, ident, image, length-percentage, resolution, string, transform-function.

To distinguish it from keywords in the attr attribute, I believe we should be more precise here and add <>.

<attr-type> = type( <syntax> ) | raw-string | number | <attr-unit>

e.g. <custom-ident>, <ident>, <image>, <length-percentage>, <resolution>, <string>, <transform-function>

css/types/attr.json

ddbeck

This looks plausible to me. One question in a line comment, but I'm happy to see this merge.

ddbeck · 2025-12-09T12:39:47Z

css/types/attr.json

+              ],
+              "support": {
+                "chrome": {
+                  "version_added": false


If <length> is supported and <percentage> is supported, what does it mean for <length-percentage> to not be supported?

github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:l [PR only] 101-1000 LoC changed labels Apr 25, 2025

skyclouds2001 mentioned this pull request Apr 25, 2025

css.types.attr - Incorrect support data for <type-or-unit> of attr() #26630

Open

caugner mentioned this pull request Apr 28, 2025

Update impl link for attr() CSS type #26625

Merged

github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Apr 28, 2025

github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Apr 28, 2025

caugner force-pushed the 25618-update-css-attr-subfeatures branch from b7ac092 to d4ea9c4 Compare April 28, 2025 08:05

caugner requested a review from Elchi3 April 28, 2025 08:11

caugner requested review from ddbeck and queengooborg May 16, 2025 12:55

caugner removed request for Elchi3 and ddbeck June 2, 2025 16:20

caugner commented Jun 12, 2025

View reviewed changes

caugner requested a review from hamishwillee June 13, 2025 15:39

caugner force-pushed the 25618-update-css-attr-subfeatures branch from 9c31c5d to eccf31e Compare July 8, 2025 12:54

caugner added 2 commits July 17, 2025 19:33

Replace angle quote entities in backticks

7060070

caugner force-pushed the 25618-update-css-attr-subfeatures branch from eccf31e to 7060070 Compare July 17, 2025 17:33

hamishwillee reviewed Jul 17, 2025

View reviewed changes

css/types/attr.json Show resolved Hide resolved

hamishwillee reviewed Jul 17, 2025

View reviewed changes

css/types/attr.json Outdated Show resolved Hide resolved

hamishwillee reviewed Jul 17, 2025

View reviewed changes

css/types/attr.json Show resolved Hide resolved

hamishwillee reviewed Jul 17, 2025

View reviewed changes

css/types/attr.json Outdated Show resolved Hide resolved

hamishwillee approved these changes Jul 17, 2025

View reviewed changes

hamishwillee mentioned this pull request Jul 18, 2025

Make CSS attr types definition list items mdn/content#40418

Merged

ddbeck mentioned this pull request Jul 22, 2025

Manually set the support status of advanced attr() web-platform-dx/web-features#3160

Closed

queengooborg removed their request for review July 23, 2025 02:59

caugner marked this pull request as draft August 14, 2025 18:50

github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 7, 2025

Merge branch 'main' into 25618-update-css-attr-subfeatures

ac88b42

caugner force-pushed the 25618-update-css-attr-subfeatures branch from 4a407dc to ac88b42 Compare November 7, 2025 15:41

caugner and others added 3 commits November 7, 2025 16:58

Add mdn/spec urls for attr subfeatures

26ef88c

fixup! Add mdn/spec urls for attr subfeatures

4a992fe

Merge branch 'main' into 25618-update-css-attr-subfeatures

4dd5b48

github-actions bot removed the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 7, 2025

fixup! Merge branch 'main' into 25618-update-css-attr-subfeatures

4c38983

caugner commented Nov 7, 2025

View reviewed changes

Apply suggestions from code review

306adf3

caugner requested a review from ddbeck November 7, 2025 16:22

caugner marked this pull request as ready for review November 7, 2025 16:22

caugner requested a review from hamishwillee November 12, 2025 09:12

Merge branch 'main' into 25618-update-css-attr-subfeatures

9936954

yisibl reviewed Nov 26, 2025

View reviewed changes

css/types/attr.json Show resolved Hide resolved

yisibl reviewed Nov 26, 2025

View reviewed changes

caugner commented Dec 5, 2025

View reviewed changes

css/types/attr.json Outdated Show resolved Hide resolved

Merge duplicate spec URL

af1eef2

caugner added the needs collector update This PR needs a corresponding update to openwebdocs/mdn-bcd-collector. label Dec 5, 2025

Merge branch 'main' into 25618-update-css-attr-subfeatures

3322c18

ddbeck approved these changes Dec 9, 2025

View reviewed changes

Fix `length-percentage> description

c272c7f

caugner merged commit 6353913 into main Dec 9, 2025
13 checks passed

caugner deleted the 25618-update-css-attr-subfeatures branch December 9, 2025 17:43

github-project-automation bot moved this from Todo to Done in BCD meeting agenda Dec 9, 2025

mdn-bot mentioned this pull request Dec 9, 2025

Release v7.2.0 #28610

Merged

tunetheweb mentioned this pull request Dec 13, 2025

Chrome 133 supports more attr functions #28661

Merged

Sync css.types.attr with CSS Values 5 extensions #26624

Sync css.types.attr with CSS Values 5 extensions #26624

Uh oh!

Conversation

caugner commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test results and supporting details

Related issues

Uh oh!

github-actions bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

caugner commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hamishwillee left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

caugner commented Nov 12, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yisibl commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ddbeck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sync `css.types.attr` with CSS Values 5 extensions #26624

Sync `css.types.attr` with CSS Values 5 extensions #26624

caugner commented Apr 25, 2025 •

edited

Loading

github-actions bot commented Apr 25, 2025 •

edited

Loading

hamishwillee left a comment •

edited

Loading

yisibl commented Nov 26, 2025 •

edited

Loading