Conversation
This PR updates and corrects version values for Firefox and Firefox Android for the `permission_screen-wake-lock` member of the `Permissions` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.12.11). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/Permissions/permission_screen-wake-lock
queengooborg
added
the
data:api
caugner
changed the title
screen-wake-lock permission
caugner
approved these changes
Apr 22, 2025
caugner
previously requested changes
Apr 22, 2025
Contributor
There was a problem hiding this comment.
I can confirm that the collector tests pass in Chrome Firefox 122 to 126.
Could we replace this support statement by two:
- Full support from 126
- Partial support from 122, removed in 126, with
notes: "The permission is available, but has no effect."
…firefox-corrections
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Elchi3
reviewed
Jul 24, 2025
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Do you want to use a range with partial implementation for Fx 122-126?
Contributor
I do think a partial implementation range from Fx 122-126 would be more correct, but I don't feel strongly about this. @queengooborg Wdyt? |
github-actions
bot
added
size:s
Elchi3
approved these changes
Aug 15, 2025
queengooborg
deleted the
api/Permissions/permission_screen-wake-lock/firefox-corrections
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects version values for Firefox and Firefox Android for the
permission_screen-wake-lockmember of thePermissionsAPI. The data comes from the mdn-bcd-collector project (v10.12.11).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/Permissions/permission_screen-wake-lock