Update position-try-options to position-try-fallbacks #23667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:css 🎨
Elchi3
requested changes
Jul 5, 2024
There was a problem hiding this comment.
Usually updates to browser/ files are done automatically but I'm fine to make an exception here to land this.
https://chromiumdash.appspot.com/schedule is the source of truth for our scripts, though and we use "Stable Release" as the date and not "Early Stable Release".
OK, got it, thanks! |
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
queengooborg
reviewed
Jul 5, 2024
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
Elchi3
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per #23651, the
position-try-optionsproperty is renamed toposition-try-fallbacksas of Chrome 128.This PR updates it.
I've also included Chrome 128 in the Chrome/Chrome Android, and Webview android browser def files so that my update will pass the tests. Let me know if that is OK, or if you want me to handle those updates differently.
Test results and supporting details
Related issues
Fixes #23651