Revert "FF124 Screen Wakelock reverted to preview"#22699
Closed
Conversation
This reverts commit d061c42.
github-actions
bot
added
data:http
Contributor
There was a problem hiding this comment.
@Elchi3 The post is confusing, but I don't think this made the release. Firstly, the last patch says it was in preview only: https://hg.mozilla.org/releases/mozilla-beta/rev/2cfab6f4b4a8#l2.13
Secondly, it doesn't pass the collector test https://mdn-bcd-collector.gooborg.com/tests/api/Navigator/wakeLock
Member
Author
|
Thanks Hamish, I thought I tested in Firefox 124 release for this, but probably not. I give up on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #22583
I think it was uplifted and made the 124 train after all. https://bugzilla.mozilla.org/show_bug.cgi?id=1883724#c8
cc @hamishwillee