Merged
Conversation
github-actions
bot
added
the
data:api
10 tasks
github-actions
bot
added
the
data:http
hamishwillee
commented
Feb 20, 2024
| } | ||
| } | ||
| }, | ||
| "permission_screen-wake-lock": { |
Contributor
Author
There was a problem hiding this comment.
Found this Permission API permission in the spec - we somehow missed it last time.
Tested with on the indicated versions (and closest I can find before). These are supported (or would otherwise have thrown in test)
(async () => {
try {
const result = await navigator.permissions.query({ name: "screen-wake-lock" });
console.log(result);
} catch (error) {
console.error(error);
}
})();
Elchi3
approved these changes
Feb 20, 2024
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Thanks! I would have caught this later this week when running our collector against the to be released Firefox 124 beta, but I will trust your research and get this in.
Also thanks for adding the Permission API permission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF124 supports the Screen Wake Lock API by default in https://bugzilla.mozilla.org/show_bug.cgi?id=1874849
This updates from preview to 124 for all things tagged with
web-features:screen-wake-lockRelated docs work can be tracked in mdn/content#32338